-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(container): build in-tree ffmpeg CLI and route imageio through it #10091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7136e98
chore(container): build in-tree ffmpeg CLI and route imageio through it
saturley-hall c55245c
fixup: re-add --disable-x86asm to ffmpeg configure
saturley-hall 4ab0ed2
Merge main into harrison/ffmpeg-vendoring
saturley-hall a5438fa
docs(deps): cross-reference --no-binary directive from imageio-ffmpeg…
saturley-hall 9aacf20
fixup: pass pip_target to uv pip in vllm; copy libvpx into dynamo_run…
saturley-hall 2f6b590
Merge remote-tracking branch 'origin/main' into harrison/ffmpeg-vendo…
saturley-hall 6996304
chore(container): move imageio-ffmpeg reinstall into requirements files
saturley-hall 9f94ffc
chore(container): ungate sglang ffmpeg copy, fix .so glob, propagate …
saturley-hall fc04a8e
chore(container): move version pins out of Dockerfiles into context.yaml
saturley-hall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Third-party Python dependencies for the sglang runtime image. Installed | ||
| # with --force-reinstall --no-deps to replace the upstream lmsysorg/sglang | ||
| # base image's imageio-ffmpeg wheel (which ships a GPL-encumbered prebuilt | ||
| # ffmpeg binary) with a source build that leaves no binary on disk. | ||
| # IMAGEIO_FFMPEG_EXE points imageio at the in-tree LGPL ffmpeg CLI. | ||
|
|
||
| --no-binary imageio-ffmpeg | ||
|
|
||
| imageio-ffmpeg>=0.6.0 # binary skipped per --no-binary directive at top of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Third-party Python dependencies for the vllm runtime image. Installed | ||
| # with --reinstall-package imageio-ffmpeg --no-deps to replace the upstream | ||
| # vllm/vllm-openai base image's imageio-ffmpeg wheel (which ships a | ||
| # GPL-encumbered prebuilt ffmpeg binary) with a source build that leaves | ||
| # no binary on disk. vLLM-Omni uses diffusers.export_to_video and doesn't | ||
| # invoke imageio-ffmpeg, so no IMAGEIO_FFMPEG_EXE is needed — this is | ||
| # purely to clear the GPL binary. | ||
|
|
||
| --no-binary imageio-ffmpeg | ||
|
|
||
| imageio-ffmpeg>=0.6.0 # binary skipped per --no-binary directive at top of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.