Skip to content

Commit 8628ed1

Browse files
committed
standardize namespace environment variable to DYN_NAMESPACE
1 parent fb10ffb commit 8628ed1

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

components/backends/sglang/deploy/disagg_planner.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
envs:
1212
- name: DYNAMO_SERVICE_CONFIG
1313
value: '{"Prometheus":{"global":{"scrape_interval":"5s"},"scrape_configs":[{"job_name":"prometheus","static_configs":[{"targets":["localhost:9090"]}]},{"job_name":"frontend","static_configs":[{"targets":["sglang-disagg-planner-frontend:8000"]}]}]}}'
14-
- name: DYNAMO_NAMESPACE
14+
- name: DYN_NAMESPACE
1515
value: "dynamo"
1616
services:
1717
Frontend:

components/backends/vllm/deploy/disagg_planner.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ spec:
1313
value: '{"Prometheus":{"global":{"scrape_interval":"5s"},"scrape_configs":[{"job_name":"prometheus","static_configs":[{"targets":["localhost:9090"]}]},{"job_name":"frontend","static_configs":[{"targets":["vllm-disagg-planner-frontend:8000"]}]}]}}'
1414
- name: DYNAMO_PORT
1515
value: "8000"
16-
- name: DYNAMO_NAMESPACE
16+
- name: DYN_NAMESPACE
1717
value: "vllm-disagg-planner"
1818
services:
1919
Frontend:

components/backends/vllm/src/dynamo/vllm/args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def parse_args() -> Config:
113113
# This becomes an `Option` on the Rust side
114114
config.served_model_name = None
115115

116-
namespace = os.environ.get("DYNAMO_NAMESPACE", "dynamo")
116+
namespace = os.environ.get("DYN_NAMESPACE", "dynamo")
117117

118118
if args.is_prefill_worker:
119119
args.endpoint = f"dyn://{namespace}.prefill.generate"

components/planner/src/dynamo/planner/defaults.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def _get_default_prometheus_endpoint(port: str, namespace: str):
7171

7272
class SLAPlannerDefaults(BasePlannerDefaults):
7373
port = os.environ.get("DYNAMO_PORT", "8000")
74-
namespace = os.environ.get("DYNAMO_NAMESPACE", "vllm-disagg-planner")
74+
namespace = os.environ.get("DYN_NAMESPACE", "vllm-disagg-planner")
7575
prometheus_endpoint = _get_default_prometheus_endpoint(port, namespace)
7676
profile_results_dir = "profiling_results"
7777
isl = 3000 # in number of tokens

0 commit comments

Comments
 (0)