Skip to content

Commit 22a75fa

Browse files
committed
Fix imports/exception logging
Signed-off-by: William Arnold <[email protected]>
1 parent dd14a5f commit 22a75fa

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

components/src/dynamo/common/config_dump/config_dumper.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ def dump_config(dump_config_to: Optional[str], config: Any) -> None:
9999
with open(dump_path.resolve(), "w", encoding="utf-8") as f:
100100
f.write(config_dump_payload)
101101
logger.info(f"Dumped config to {dump_path.resolve()}")
102-
except (OSError, IOError) as e:
103-
logger.exception(f"Failed to dump config to {dump_config_to}: {e}")
102+
except (OSError, IOError):
103+
logger.exception(f"Failed to dump config to {dump_config_to}")
104104
logger.info(f"CONFIG_DUMP: {config_dump_payload}")
105-
except Exception as e:
106-
logger.exception(f"Unexpected error dumping config: {e}")
105+
except Exception:
106+
logger.exception("Unexpected error dumping config")
107107
logger.info(f"CONFIG_DUMP: {config_dump_payload}")
108108
else:
109109
logger.info(f"CONFIG_DUMP: {config_dump_payload}")
@@ -200,7 +200,7 @@ def register_encoder(type_class):
200200
def encode_my_class(obj: MyClass):
201201
return {"field": obj.field}
202202
"""
203-
logger.verbose(f"Registering encoder for {type_class}")
203+
logger.debug(f"Registering encoder for {type_class}")
204204
return _preprocess_for_encode.register(type_class)
205205

206206

components/src/dynamo/vllm/args.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,13 @@
66
import os
77
from typing import Any, Dict, Optional
88

9-
from components.common.src.dynamo.common.utils import register_encoder
109
from vllm.config import KVTransferConfig
1110
from vllm.distributed.kv_events import KVEventsConfig
1211
from vllm.engine.arg_utils import AsyncEngineArgs
1312
from vllm.utils import FlexibleArgumentParser
1413

1514
from dynamo._core import get_reasoning_parser_names, get_tool_parser_names
16-
from dynamo.common.config_dump import add_config_dump_args
15+
from dynamo.common.config_dump import add_config_dump_args, register_encoder
1716
from dynamo.runtime import DistributedRuntime
1817

1918
from . import __version__

0 commit comments

Comments
 (0)