Page Info Overlay #159
Merged
Page Info Overlay #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jazakAllah khair - we need to refactor stuff out of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for overlaying page info (pg #, sura name, and juz2 #).
Beta for now. Just in case, surrounded the 2 entry points with catch-all to avoid FC's... at least until after Ramadan :)
It determines the empty gap between the top of the ImageView and the top of the actual bitmap. If the gap is large enough, it draws the text within that gap. If not, it uses the ayah-info database to get the actual location of the top of the first line, and utilizes that gap as well for drawing (i.e. between top of bitmap and top of highest glyph). A side effect is that on pages where a sura starts there is a huge gap (either because of basmallah or because of the decoration with sura name) and so it partly overlaps on that.
Should check for ayah-info files, but wasn't sure if it's a good idea because then the user would be asked every time they view a page. For now the "catch all" should take care of it..