You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When enforcing a shorter max_new_tokens limit sometimes it cuts replies in a way that leaves a lonely * or " at the end of the message, this can happen in 2 ways, sometimes it's in the same line, sometimes it's in a new line immediately after a complete sentence.
Describe the solution you'd like
Punctuation should be trimmed with the rest of the incomplete response if preceded by a (as appearing outside of edit mode) whitespace. Similar to SillyTavern/SillyTavern#1780.
Describe alternatives you've considered
I have tried adding possible matching entries to the list of Stop Sequences but this doesn't seem to be related to the issue or have any effect.
Additional context
Examples of undesirable responses due to trimming leaving some characters behind, notice at the end of responses:
*User's heart races, torn between his desire for her and his sense of self-worth. But deep down, he knows that he's in too deep, and there's no going back.*
*
*Her smile broadens at your words of gratitude.* "That's good. Now let's forget about all the troubles and just enjoy our time together, alright?" *She suggests with a playful wink, indicating she has more surprises in store for her loving boyfriend.* "But first, how about I make you some of your favorite dinner?" *
Screenshots:
The text was updated successfully, but these errors were encountered:
Spacellary
changed the title
Feature Enchantment: Improve "Trim Incomplete Sentences" detection.
Feature Enhancement: Improve "Trim Incomplete Sentences" detection.
Feb 14, 2024
Is your feature request related to a problem? Please describe.
When enforcing a shorter max_new_tokens limit sometimes it cuts replies in a way that leaves a lonely
*
or"
at the end of the message, this can happen in 2 ways, sometimes it's in the same line, sometimes it's in a new line immediately after a complete sentence.Describe the solution you'd like
Punctuation should be trimmed with the rest of the incomplete response if preceded by a (as appearing outside of edit mode) whitespace. Similar to SillyTavern/SillyTavern#1780.
Describe alternatives you've considered
I have tried adding possible matching entries to the list of Stop Sequences but this doesn't seem to be related to the issue or have any effect.
Additional context
Examples of undesirable responses due to trimming leaving some characters behind, notice at the end of responses:
Screenshots:
The text was updated successfully, but these errors were encountered: