Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 17 support in peerDeps range #58

Closed
mihkeleidast opened this issue Nov 10, 2020 · 13 comments · Fixed by #69
Closed

React 17 support in peerDeps range #58

mihkeleidast opened this issue Nov 10, 2020 · 13 comments · Fixed by #69
Labels
scope: dependencies Pull requests that update a dependency file solution: workaround available A workaround is available for this issue

Comments

@mihkeleidast
Copy link

This module does not currently allow React 17 in it's peerDependency range. Requesting that this would be allowed.
@agilgur5
Copy link
Owner

Yea was planning on making that change soon. Should probably work fine with React 17 since it only changes event capture and react-signature-canvas and signature_pad don't rely on React's event capture.

I'll have to update the devDep and make sure tests pass first. Might get to it in the coming week as I've been looking to get back to this library and make some merges I put off.

In any case, it's just a warning, so it should not be a blocker.

@agilgur5 agilgur5 added the solution: workaround available A workaround is available for this issue label Nov 13, 2020
@mihkeleidast
Copy link
Author

Would you accept a PR if everything works? I like to strictly follow peerDependency ranges so this may block our upgrade soon.

@ctrlaltdylan
Copy link

Would also be open to lend a hand if needed

@JenRuey

This comment has been minimized.

Sign in to view
@mihkeleidast
Copy link
Author

Now that npm v7 has been released, this is becoming more of a blocker to upgrading. npm@7 throws an error if peerDeps cannot be resolved correctly.

@durgeshrkumari

This comment has been minimized.

Sign in to view
@ashen780
Copy link

ashen780 commented Sep 21, 2021 •
edited
Loading

any quick workaround to make this work on react 17?
edit:
found this compatible version https://www.npmjs.com/package/react-signature-canvas-react17-compatible

@luke9216

This comment has been minimized.

Sign in to view
@filkalny-thimble

This comment has been minimized.

Sign in to view
@luke9216
Copy link

luke9216 commented Oct 29, 2021 •
edited
Loading

Hi all. I have created an npm package as a workaround for the React 17 issue https://www.npmjs.com/package/react-signature-drawing. This has a direct dependency on this project. This should be used until agilgur5 is back

@jmalbite
Copy link

Hi @luke9216 how to use your package?

@Sean-Y-X

This comment was marked as spam.

Sign in to view
@agilgur5 agilgur5 added the scope: dependencies Pull requests that update a dependency file label Feb 6, 2022
@agilgur5 agilgur5 linked a pull request Feb 7, 2022 that will close this issue
add React 17 to peerDep range -- needs to update devDeps and tests #64
Closed
@agilgur5 agilgur5 changed the title React 17 support React 17 support in peerDeps range Feb 7, 2022
@agilgur5 agilgur5 mentioned this issue Feb 9, 2022
Merged
@agilgur5
Copy link
Owner

agilgur5 commented Feb 9, 2022

Released in v1.0.5

Repository owner locked as resolved and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope: dependencies Pull requests that update a dependency file solution: workaround available A workaround is available for this issue
Projects
None yet
Milestone
No milestone
10 participants
@mihkeleidast @ctrlaltdylan @agilgur5 @durgeshrkumari @luke9216 @Sean-Y-X @JenRuey @ashen780 @jmalbite @filkalny-thimble