Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VirtualEnv creation flags (e.g. --python=...) #392

Open
andyk opened this issue Jun 5, 2022 · 1 comment
Open

Support VirtualEnv creation flags (e.g. --python=...) #392

andyk opened this issue Jun 5, 2022 · 1 comment
Assignees

Comments

@andyk
Copy link
Contributor

andyk commented Jun 5, 2022

Flags that can be passed when creating a virtualenv should be supported.

I ran into this when i started an EC2 instance running a recent Ubuntu and ran:

cd example_agents/acme_dqn
agentos run agent

The VirtualEnv got created with Python 3.10.4 interpreter, which we don't support yet.

One solution would be to make VirtualEnv a PCS Component with attributes:

  • python_version
  • requirements_path
@andyk andyk self-assigned this Jun 5, 2022
@andyk andyk moved this to Todo in Sprint 0.2.1 Jun 5, 2022
@andyk andyk moved this from Todo to In Progress in Sprint 0.2.1 Jun 5, 2022
@nickjalbert
Copy link
Contributor

I think I like the idea of explicitly representing the venv in the Component DAG. Where would it attach? The command? Or the root Component?

I guess the root Component would be the closest to the system we have now (and is convenient because the Component usually has the requirements.txt in its repo). The VirtualEnv spec would probably have a repo too, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants