Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [Shelved for V2.0] Public User Index #130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ShamiTomita
Copy link
Contributor

@ShamiTomita ShamiTomita commented Sep 23, 2023

Ticket/Issue, What does this resolve?

Resolves #123

Open Questions:

  • Who should be able to see this directory? I feel like Private users shouldn't be able too, but if a user's profile is public they're able to show it anyone regardless if they're a registered public/private user or not.

Description

This PR

  • Creates a user directory that is only accessible to registered users who have set their profiles to public.
  • Does not allow private Users to view the directory through a callback :no_creeps . Still allows them to view User show pages, not sure if that should change
  • Adds a button for the User directory to nav

QA Notes and Testing

Working on it

Screenshot/Video

userindex_sm.mov
Screenshot 2023-09-23 at 4 30 41 PM Screenshot 2023-09-23 at 4 31 07 PM

Feelings gif (optional)

@ShamiTomita ShamiTomita changed the title WIP Public User Index WIP [Shelved for V2.0] Public User Index Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an Attendee Directory
1 participant