Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terrafirmacraft ores to autominer support list #195

Open
netherever opened this issue Nov 18, 2019 · 12 comments
Open

Add terrafirmacraft ores to autominer support list #195

netherever opened this issue Nov 18, 2019 · 12 comments
Labels

Comments

@netherever
Copy link

Scanner (portable and autominer) don't see TFC ores - therefore, no automaining/
This is sad.

@jrddunbr jrddunbr self-assigned this Nov 18, 2019
@jrddunbr jrddunbr added the bug A bug has been found! label Nov 18, 2019
@jrddunbr
Copy link
Collaborator

Hmmm. I'm pretty sure those were reported working a while back with the autominer. I have screenshots of a world with a working TFC autominer, at least.

@jrddunbr
Copy link
Collaborator

I'll look into it.

@jrddunbr jrddunbr added this to the Someday milestone Nov 18, 2019
@netherever
Copy link
Author

netherever commented Nov 19, 2019

It's pretty obviously - ores from tfc very different to vanilla (technicaly - it's block of rock), so scanner see just that.

@jrddunbr
Copy link
Collaborator

No, I'm aware of that. I think there's a config or something like that because it worked previously and I haven't made any recent changes to the logic it uses.

@netherever
Copy link
Author

No, already checking source - it's just can't work with tfc ores.
Obviously - this never tried.

@jrddunbr
Copy link
Collaborator

I swear, I've seen it done before. But if you're familiar with the source at this point, feel free to check out 1.15.x stable and submit a pull request for it. I'm sure it's not many lines.

@netherever
Copy link
Author

netherever commented Nov 19, 2019

I'm sure it's not many lines.

Wrong.
At least need to use tfc api.
But let's take it ease.
Just take as ore any block with entity - this be enough.

@jrddunbr
Copy link
Collaborator

feel free to check out 1.15.x stable and submit a pull request for it.

If you don't submit something, I'll look at it probably this weekend, but I can't guarantee that I'll get it working because I'm pretty busy these days. :/

@netherever
Copy link
Author

Done (hope will work)

@jrddunbr
Copy link
Collaborator

I'll test things out tonight. I'm concerned about one part of the code, I'm not convinced that it won't just take any tile entity and just mark it as an ore. That would be bad. I'll verify tonight.

@netherever
Copy link
Author

It's not right thing, true.
But not so bad - work only if set in config, and see (and mined) chest by xray is sort of fun.

@jrddunbr jrddunbr added the 1.12 label Jan 7, 2020
@jrddunbr
Copy link
Collaborator

jrddunbr commented Jan 7, 2020

This issue is being closed now since there will be no more feature updates in Electrical Age for Minecraft 1.7.10.
If the issue is relevant to 1.12, it will be re-opened there at a later date.

@jrddunbr jrddunbr closed this as completed Jan 7, 2020
@jrddunbr jrddunbr reopened this Jul 24, 2023
@jrddunbr jrddunbr added enhancement help wanted and removed 1.12 bug A bug has been found! labels Jul 24, 2023
@jrddunbr jrddunbr removed their assignment Jul 24, 2023
@jrddunbr jrddunbr added the code work Needs code implementation label Aug 6, 2023
@jrddunbr jrddunbr changed the title terrafirmacraft ores Add terrafirmacraft ores to autominer support list Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants