Skip to content

Commit 28df205

Browse files
jaysoojaysoo
authored
chore(repo): replace dep check script with new lint rule (nrwl#18060)
1 parent b73f980 commit 28df205

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+643
-740
lines changed

‎.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ jobs:
187187
pnpm nx-cloud record -- nx format:check --base=$NX_BASE --head=$NX_HEAD &
188188
pids+=($!)
189189
190-
pnpm nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners documentation --parallel=1 --no-dte &
190+
pnpm nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte &
191191
pids+=($!)
192192
193193
pnpm nx affected --target=lint --base=$NX_BASE --head=$NX_HEAD --parallel=3 &

‎CODEOWNERS

-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ pnpm-lock.yaml @nrwl/nx-pipelines-reviewers
161161
/CODEOWNERS @FrozenPandaz @AgentEnder
162162

163163
# Scripts
164-
/scripts/depcheck @FrozenPandaz @vsavkin @jaysoo
165164
/scripts/documentation @nrwl/nx-docs-reviewers
166165
/scripts/angular-support-upgrades @nrwl/nx-angular-reviewers
167166

‎package.json

-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"nx-release": "ts-node -P ./scripts/tsconfig.release.json ./scripts/nx-release",
1616
"prepublishOnly": "node ./scripts/update-package-group.js",
1717
"version": "pnpm prettier lerna.json --write",
18-
"depcheck": "ts-node -P ./scripts/tsconfig.scripts.json ./scripts/depcheck",
1918
"local-registry": "nx local-registry @nx/nx-source",
2019
"documentation": "ts-node -P scripts/tsconfig.scripts.json ./scripts/documentation/generators/main.ts && pnpm check-documentation-map",
2120
"submit-plugin": "node ./scripts/submit-plugin.js",
@@ -153,7 +152,6 @@
153152
"cytoscape-popper": "^2.0.0",
154153
"cz-git": "^1.4.0",
155154
"czg": "^1.4.0",
156-
"depcheck": "^1.3.1",
157155
"detect-port": "^1.5.1",
158156
"dotenv": "~10.0.0",
159157
"ejs": "^3.1.7",
@@ -352,7 +350,6 @@
352350
"check-imports",
353351
"check-lock-files",
354352
"check-codeowners",
355-
"depcheck",
356353
"documentation"
357354
]
358355
},

‎packages/angular/.eslintrc.json

+61
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,67 @@
3333
"rules": {
3434
"@nx/nx-plugin-checks": "error"
3535
}
36+
},
37+
{
38+
"files": ["./package.json"],
39+
"parser": "jsonc-eslint-parser",
40+
"rules": {
41+
"@nx/dependency-checks": [
42+
"error",
43+
{
44+
"buildTargets": ["build-base"],
45+
"ignoredDependencies": [
46+
"nx",
47+
"eslint",
48+
"rxjs",
49+
"semver",
50+
// These are installed by ensurePackage so missing in package.json
51+
"@nx/cypress",
52+
"@nx/jest",
53+
"@nx/rollup",
54+
"@nx/storybook",
55+
"@nx/vite",
56+
"@nx/webpack",
57+
"prettier",
58+
"typescript",
59+
// These are installed by generators
60+
"@angular-devkit/core",
61+
"@angular-devkit/architect",
62+
"@angular-devkit/build-angular",
63+
"@angular-devkit/schematics",
64+
"@angular/compiler",
65+
"@angular/compiler-cli",
66+
"@angular/core",
67+
"@angular/router",
68+
"@ngrx/effects",
69+
"@ngrx/router-store",
70+
"@ngrx/store",
71+
"@storybook/angular",
72+
"@module-federation/node",
73+
// installed dynamically by the library generator
74+
"ng-packagr",
75+
// ng-packagr deps, some are handled if not installed
76+
"injection-js",
77+
"browserslist",
78+
"cacache",
79+
"less",
80+
"node-sass",
81+
"node-sass-tilde-importer",
82+
"ora",
83+
"convert-source-map",
84+
"postcss",
85+
"postcss-import",
86+
"postcss-preset-env",
87+
"postcss-url",
88+
"sass",
89+
"stylus",
90+
"tailwindcss",
91+
// used in the CT angular plugin where Cy is already installed to use it.
92+
"cypress"
93+
]
94+
}
95+
]
96+
}
3697
}
3798
]
3899
}

‎packages/angular/package.json

+2-3
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,14 @@
4848
"@phenomnomnominal/tsquery": "~5.0.1",
4949
"@typescript-eslint/type-utils": "^5.36.1",
5050
"chalk": "^4.1.0",
51-
"chokidar": "^3.5.1",
5251
"find-cache-dir": "^3.3.2",
53-
"http-server": "^14.1.0",
5452
"ignore": "^5.0.4",
5553
"magic-string": "~0.26.2",
5654
"minimatch": "3.0.5",
5755
"semver": "7.5.3",
56+
"tslib": "^2.3.0",
5857
"webpack": "^5.80.0",
59-
"webpack-merge": "5.7.3",
58+
"webpack-merge": "^5.8.0",
6059
"enquirer": "^2.3.6",
6160
"@nx/cypress": "file:../cypress",
6261
"@nx/devkit": "file:../devkit",

‎packages/create-nx-plugin/.eslintrc.json

+12
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,18 @@
2424
{
2525
"files": ["*.js", "*.jsx"],
2626
"rules": {}
27+
},
28+
{
29+
"files": ["./package.json"],
30+
"parser": "jsonc-eslint-parser",
31+
"rules": {
32+
"@nx/dependency-checks": [
33+
"error",
34+
{
35+
"buildTargets": ["build-base"]
36+
}
37+
]
38+
}
2739
}
2840
]
2941
}

‎packages/create-nx-plugin/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
"create-nx-workspace": "file:../create-nx-workspace",
3333
"chalk": "^4.1.0",
3434
"enquirer": "~2.3.6",
35+
"tslib": "^2.3.0",
3536
"yargs": "^17.6.2"
3637
},
3738
"publishConfig": {

‎packages/create-nx-workspace/.eslintrc.json

+12
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,18 @@
2424
{
2525
"files": ["*.js", "*.jsx"],
2626
"rules": {}
27+
},
28+
{
29+
"files": ["./package.json"],
30+
"parser": "jsonc-eslint-parser",
31+
"rules": {
32+
"@nx/dependency-checks": [
33+
"error",
34+
{
35+
"buildTargets": ["build-base"]
36+
}
37+
]
38+
}
2739
}
2840
]
2941
}

‎packages/cypress/.eslintrc.json

+20
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,26 @@
2424
"rules": {
2525
"@nx/nx-plugin-checks": "error"
2626
}
27+
},
28+
{
29+
"files": ["./package.json"],
30+
"parser": "jsonc-eslint-parser",
31+
"rules": {
32+
"@nx/dependency-checks": [
33+
"error",
34+
{
35+
"buildTargets": ["build-base"],
36+
"ignoredDependencies": [
37+
"nx",
38+
"typescript",
39+
// Type imports only
40+
"eslint",
41+
"rollup",
42+
"vite"
43+
]
44+
}
45+
]
46+
}
2747
}
2848
],
2949
"ignorePatterns": ["!**/*"]

‎packages/cypress/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@
3535
},
3636
"dependencies": {
3737
"@phenomnomnominal/tsquery": "~5.0.1",
38+
"detect-port": "^1.5.1",
3839
"dotenv": "~10.0.0",
3940
"semver": "7.5.3",
40-
"detect-port": "^1.5.1",
41+
"tslib": "^2.3.0",
4142
"@nx/devkit": "file:../devkit",
4243
"@nx/js": "file:../js",
4344
"@nx/linter": "file:../linter"

‎packages/detox/.eslintrc.json

+13
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,19 @@
1414
"rules": {
1515
"@nx/nx-plugin-checks": "error"
1616
}
17+
},
18+
{
19+
"files": ["./package.json"],
20+
"parser": "jsonc-eslint-parser",
21+
"rules": {
22+
"@nx/dependency-checks": [
23+
"error",
24+
{
25+
"buildTargets": ["build-base"],
26+
"ignoredDependencies": ["nx", "typescript", "detox"]
27+
}
28+
]
29+
}
1730
}
1831
]
1932
}

‎packages/detox/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
"@nx/jest": "file:../jest",
3030
"@nx/js": "file:../js",
3131
"@nx/linter": "file:../linter",
32-
"@nx/react": "file:../react"
32+
"@nx/react": "file:../react",
33+
"tslib": "^2.3.0"
3334
},
3435
"peerDependencies": {
3536
"detox": "^20.9.0"

‎packages/devkit/.eslintrc.json

+23
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,29 @@
5050
"rules": {
5151
"@nx/nx-plugin-checks": "error"
5252
}
53+
},
54+
{
55+
"files": ["./package.json"],
56+
"parser": "jsonc-eslint-parser",
57+
"rules": {
58+
"@nx/dependency-checks": [
59+
"error",
60+
{
61+
"buildTargets": ["build-base"],
62+
"ignoredDependencies": [
63+
"nx",
64+
"typescript",
65+
"prettier",
66+
// Installed to workspace by plugins
67+
"rxjs",
68+
"@angular-devkit/core",
69+
"@angular-devkit/architect",
70+
"@angular-devkit/schematics",
71+
"webpack"
72+
]
73+
}
74+
]
75+
}
5376
}
5477
]
5578
}

‎packages/esbuild/.eslintrc.json

+13
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,19 @@
2020
"rules": {
2121
"@nx/nx-plugin-checks": "error"
2222
}
23+
},
24+
{
25+
"files": ["./package.json"],
26+
"parser": "jsonc-eslint-parser",
27+
"rules": {
28+
"@nx/dependency-checks": [
29+
"error",
30+
{
31+
"buildTargets": ["build-base"],
32+
"ignoredDependencies": ["nx", "typescript", "esbuild"]
33+
}
34+
]
35+
}
2336
}
2437
]
2538
}

‎packages/eslint-plugin/.eslintrc.json

+20
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,26 @@
2222
{
2323
"files": ["*.js", "*.jsx"],
2424
"rules": {}
25+
},
26+
{
27+
"files": ["./package.json"],
28+
"parser": "jsonc-eslint-parser",
29+
"rules": {
30+
"@nx/dependency-checks": [
31+
"error",
32+
{
33+
"buildTargets": ["build-base"],
34+
"ignoredDependencies": [
35+
"nx",
36+
"typescript",
37+
// Installed to workspace by plugins
38+
"@typescript-eslint/parser",
39+
"eslint-config-prettier",
40+
"@angular-eslint/eslint-plugin"
41+
]
42+
}
43+
]
44+
}
2545
}
2646
]
2747
}

‎packages/eslint-plugin/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"chalk": "^4.1.0",
4141
"confusing-browser-globals": "^1.0.9",
4242
"jsonc-eslint-parser": "^2.1.0",
43-
"semver": "7.5.3"
43+
"semver": "7.5.3",
44+
"tslib": "^2.3.0"
4445
},
4546
"publishConfig": {
4647
"access": "public"

‎packages/expo/.eslintrc.json

+24
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,30 @@
1414
"rules": {
1515
"@nx/nx-plugin-checks": "error"
1616
}
17+
},
18+
{
19+
"files": ["./package.json"],
20+
"parser": "jsonc-eslint-parser",
21+
"rules": {
22+
"@nx/dependency-checks": [
23+
"error",
24+
{
25+
"buildTargets": ["build-base"],
26+
"ignoredDependencies": [
27+
"nx",
28+
"@nx/rollup",
29+
"@nx/webpack",
30+
"typescript",
31+
"eslint",
32+
"expo",
33+
"react",
34+
"@expo/cli",
35+
"eas-cli",
36+
"util" // This is coming from @storybook/builder-manager since it uses the browser polyfill
37+
]
38+
}
39+
]
40+
}
1741
}
1842
]
1943
}

‎packages/expo/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"metro-resolver": "0.76.7",
3434
"node-fetch": "^2.6.7",
3535
"tar-fs": "^2.1.1",
36+
"tslib": "^2.3.0",
3637
"tsconfig-paths": "^4.1.2",
3738
"tsconfig-paths-webpack-plugin": "^4.0.0",
3839
"@nx/detox": "file:../detox",

‎packages/express/.eslintrc.json

+19
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,25 @@
3434
"rules": {
3535
"@nx/nx-plugin-checks": "error"
3636
}
37+
},
38+
{
39+
"files": ["./package.json"],
40+
"parser": "jsonc-eslint-parser",
41+
"rules": {
42+
"@nx/dependency-checks": [
43+
"error",
44+
{
45+
"buildTargets": ["build-base"],
46+
"ignoredDependencies": [
47+
"nx",
48+
"@nx/linter",
49+
"typescript",
50+
"eslint",
51+
"express"
52+
]
53+
}
54+
]
55+
}
3756
}
3857
]
3958
}

0 commit comments

Comments
 (0)