-
Notifications
You must be signed in to change notification settings - Fork 208
[ENH] Change fitted estimators and ensemble collections from protected to public #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
enhancement
New feature, improvement request or other non-bug code enhancement
Comments
see #2350 for an example |
@@aeon-actions-bot assign @vedpawar2254 |
@aeon-actions-bot assign @aryan0931 |
@vedpawar2254 the comment has to be made in a new post, just saw this now. See the contributor guide on the webpage. |
@aryan0931 do you still intend to create a PR for this? |
yes I am working on that. |
@aeon-actions-bot assign @Sharathchenna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature or idea you want to propose
Currently in a lot of estimators we fit an sklearn estimator i.e.
_estimator
or form an ensemble of estimators i.e._ensemble
or_classifiers
but these are protected (starting with an_
).Theres not much reason for them to be protected IMO.
Describe your proposed solution
Change fitted estimator attributes from protected to public using our fitted attribute convention i.e. from
_estimator
toestimator_
.These should then be properly documented in the estimator docstring under "Attributes"
Describe alternatives you've considered, if relevant
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: