Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implement the Proximity Forest 2 classifier using aeon distances #428

Open
TonyBagnall opened this issue May 13, 2023 · 2 comments · May be fixed by #1978
Open

[ENH] Implement the Proximity Forest 2 classifier using aeon distances #428

TonyBagnall opened this issue May 13, 2023 · 2 comments · May be fixed by #1978
Labels
classification Classification package distances Distances package enhancement New feature, improvement request or other non-bug code enhancement implementing algorithms Implementing new algorithms/estimators

Comments

@TonyBagnall
Copy link
Contributor

Describe the feature or idea you want to propose

a new distance based classifier, Proximity Forest 2, has recently been proposed. This is probably the current best distance based algorithm for time series classification (we have not used it yet). IT would be fantastic to have an aeon implementation.

https://arxiv.org/abs/2304.05800

Describe your proposed solution

It should probably be done in conjunction with #159 (or instead of #159?) using aeon distance functions.

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package implementing algorithms Implementing new algorithms/estimators distances Distances package labels May 13, 2023
@hadifawaz1999
Copy link
Member

I think it should be instead of #159 , unless someone already started to work on it, if not then yeah we can skip it and go directly to PF2

@GuiArcencio
Copy link
Contributor

GuiArcencio commented May 16, 2023

I can work on this since I've implemented PF before, I could have a working draft around next week or so. One possible issue for PF2 is that it requires different cost functions for DTW calculations (||a - b||^0.5, 1, or 2), which I think are fixed in our implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package distances Distances package enhancement New feature, improvement request or other non-bug code enhancement implementing algorithms Implementing new algorithms/estimators
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants