Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Port no longer showing in podcasts generated in 2.17.5 and newer #3809

Open
andrewinmoco opened this issue Jan 7, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@andrewinmoco
Copy link

What happened?

After upgrading to the current audiobookshelf I'm unable play RSS feeds generated ion my podcast player. When investigating this I found that the port for the web server is no longer included in the generated RSS feed which means that the MP3 files can't be downloaded.

Working item from RSS feed generated in 2.17.4
image

Non working item from RSS feed generated in 2.17.5
image

What did you expect to happen?

I expect the port to be included in the URL to download the JPG and the MP3.

Steps to reproduce the issue

  1. Generate a RSS feed for a book while not on port 443
  2. Attempt to load the RSS feed in a podcast reader

Audiobookshelf version

v2.17.7

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

No response

Additional Notes

No response

@andrewinmoco andrewinmoco added the bug Something isn't working label Jan 7, 2025
@advplyr
Copy link
Owner

advplyr commented Jan 8, 2025

I see that this is a bug with express stripping the port. It doesn't strip the port number in all cases though so I haven't reproduced the issue.

https://expressjs.com/en/guide/migrating-5.html#req.host

In Express 4, the req.host function incorrectly stripped off the port number if it was present. In Express 5, the port number is maintained.

We can see about migrating to express 5 to resolve this.

Relevant PR #3692 @mikiher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants