Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An "unsafeMerge" option for faster cell merging (without overlapping checks) #33

Open
shk-webpr opened this issue Sep 27, 2022 · 3 comments

Comments

@shk-webpr
Copy link

Is your feature request related to a problem? Please describe.
The more merged cells worksheet has, the longer it takes to add a new merged cell. Most of this time is spent checking to see if currently merged cells contain cells in new merge request.

Describe the solution you'd like
An worksheet option for bypassing these checks.

Describe alternatives you've considered
A cell() method argument for bypassing these checks.

Additional context
https://github.com/advisr-io/excel4node/blob/master/source/lib/cell/index.js#L231
image

@wildhart
Copy link

I'm having this issue too - is there any timeline to make it possible to avoid these checks? I'm happy for my own code to take responsibility for preventing overlapping merged cells...

@danielb7390
Copy link

You can just use the patch-package tool to remove that part of the code from your codebase. That's what i did...

@wildhart
Copy link

Thanks @danielb7390 - I've done that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants