You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there, thanks a stack for conceiving this recipe. We observed a little problem we originally reported over here. Hereby, we are re-creating it as a dedicated issue, as we believe it makes sense instead of hijacking the other conversation.
We are trying here to introduce inline admonition suppressions (through a PR), and would like to see exactly the behaviour as described by @aibaars at github/codeql#11427 (comment), even if it might not be perfect for some.
Now, when trying to let advanced-security/dismiss-alerts run on any branch by removing the if: github.ref == 'refs/heads/main' constraint, the CI workflow trips.
We are trying here to introduce inline admonition suppressions (through a PR), and would like to see exactly the behaviour as described by @aibaars at github/codeql#11427 (comment), even if it might not be perfect for some.
The reason for the if: github.ref == 'refs/heads/main' constraint is that otherwise a pull request with a suppression annotation will dismiss the alert on all branches and pull requests, even if the pull request is not merged. I'd expect subsequent analysis runs on any other branches or pull requests to re-open the alert again, so the behaviour is likely to be really annoying an confusing.
That said, go ahead and try for yourself. If the volume of changes to the repository is low it might actually work out fine.
Hi there, thanks a stack for conceiving this recipe. We observed a little problem we originally reported over here. Hereby, we are re-creating it as a dedicated issue, as we believe it makes sense instead of hijacking the other conversation.
We are trying here to introduce inline admonition suppressions (through a PR), and would like to see exactly the behaviour as described by @aibaars at github/codeql#11427 (comment), even if it might not be perfect for some.
Now, when trying to let
advanced-security/dismiss-alerts
run on any branch by removing theif: github.ref == 'refs/heads/main'
constraint, the CI workflow trips.-- https://github.com/crate/crate-python/actions/runs/11827873067/job/32956862592?pr=676
The text was updated successfully, but these errors were encountered: