Skip to content

Commit 5862e5d

Browse files
Merge pull request #104 from advanced-security/jeongsoolee09/cover-missing-xss
Cover missing XSS vulnerability
2 parents 4d71c2c + 2d4c896 commit 5862e5d

File tree

24 files changed

+719
-39
lines changed

24 files changed

+719
-39
lines changed

javascript/frameworks/ui5/ext/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
library: true
33
name: advanced-security/javascript-sap-ui5-models
4-
version: 0.5.0
4+
version: 0.6.0
55
extensionTargets:
66
codeql/javascript-all: "^0.8.7"
77
dataExtensions:

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/RemoteFlowSources.qll

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,18 @@ private class RouteParameterAccess extends RemoteFlowSource instanceof PropRead
123123
}
124124
}
125125

126+
private class DisplayEventHandlerParameterAccess extends RemoteFlowSource instanceof PropRead {
127+
override string getSourceType() { result = "DisplayEventHandlerParameterAccess" }
128+
129+
DisplayEventHandlerParameterAccess() {
130+
exists(DisplayEventHandler handler, MethodCallNode getParameterCall |
131+
getParameterCall.getMethodName() = "getParameter" and
132+
this.getBase().getALocalSource() = getParameterCall and
133+
handler.getParameter(0) = getParameterCall.getReceiver().getALocalSource()
134+
)
135+
}
136+
}
137+
126138
/**
127139
* Method calls that fetch a piece of data either from a library control capable of accepting user input, or from a URI parameter.
128140
*/

0 commit comments

Comments
 (0)