From 2cd8d2be0555ce598ec19d25ceed117ca354f128 Mon Sep 17 00:00:00 2001
From: jonathansligh-nimbus <jonathan@nimbus.co>
Date: Wed, 18 Sep 2024 11:07:39 -0500
Subject: [PATCH] Fixing RTB Tests Copied from OpenRTB Repo (#49)

Cleaned up and updated to run tests from ORTB Repo in a new set of Github actions.
---
 .github/workflows/rtbworkflow.yml                         | 3 +--
 .../Runtime/Plugins/RTB.Tests/OpenRTB.Tests.csproj        | 8 ++++----
 .../Runtime/Plugins/RTB.Tests/packages.config             | 6 +++---
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/rtbworkflow.yml b/.github/workflows/rtbworkflow.yml
index bcb6a0ec..e545c3c4 100644
--- a/.github/workflows/rtbworkflow.yml
+++ b/.github/workflows/rtbworkflow.yml
@@ -11,7 +11,6 @@ on:
       - 'com.adsbynimbus.nimbus/Runtime/Plugins/**'
       - '.github/workflows/rtbworkflow*'
 
-
 jobs:
   tests:
     name: Running CSharp Tests
@@ -22,7 +21,7 @@ jobs:
 
       - name: Setup dotnet
         uses: actions/setup-dotnet@v4
-
+        
       - uses: actions/cache@v4
         with:
           path: ~/.nuget/packages
diff --git a/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/OpenRTB.Tests.csproj b/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/OpenRTB.Tests.csproj
index 02060100..d41bc04d 100644
--- a/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/OpenRTB.Tests.csproj
+++ b/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/OpenRTB.Tests.csproj
@@ -2,7 +2,7 @@
 <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
     <Import Project="..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props" Condition="Exists('..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props')" />
     <Import Project="..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props" Condition="Exists('..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props')" />
-    <Import Project="..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props" Condition="Exists('..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props')" />
+    <Import Project="..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props" Condition="Exists('..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props')" />
     <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
     <PropertyGroup>
         <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -46,8 +46,8 @@
         <Reference Include="System.Core" />
         <Reference Include="System.Data" />
         <Reference Include="System.Xml" />
-        <Reference Include="nunit.framework, Version=3.5.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb">
-            <HintPath>..\packages\NUnit.3.5.0\lib\net45\nunit.framework.dll</HintPath>
+        <Reference Include="nunit.framework, Version=3.14.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb">
+            <HintPath>..\packages\NUnit.3.14.0\lib\net45\nunit.framework.dll</HintPath>
         </Reference>
     </ItemGroup>
     <ItemGroup>
@@ -68,7 +68,7 @@
       <PropertyGroup>
         <ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105.The missing file is {0}.</ErrorText>
       </PropertyGroup>
-      <Error Condition="!Exists('..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props'))" />
+      <Error Condition="!Exists('..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props'))" />
       <Error Condition="!Exists('..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props'))" />
       <Error Condition="!Exists('..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.targets'))" />
       <Error Condition="!Exists('..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props'))" />
diff --git a/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/packages.config b/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/packages.config
index 855b29d7..dde7ca31 100644
--- a/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/packages.config
+++ b/com.adsbynimbus.nimbus/Runtime/Plugins/RTB.Tests/packages.config
@@ -1,8 +1,8 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <packages>
   <package id="Microsoft.CodeCoverage" version="17.2.0" targetFramework="net46" />
   <package id="Microsoft.NET.Test.Sdk" version="17.2.0" targetFramework="net46" />
-  <package id="NUnit" version="3.5.0" targetFramework="net45" />
-  <package id="NUnit3TestAdapter" version="4.2.1" targetFramework="net46" />
+  <package id="NUnit" version="3.14.0" targetFramework="net45" />
+  <package id="NUnit3TestAdapter" version="4.4.2" targetFramework="net46" />
   <package id="Newtonsoft.Json" version="13.0.1" targetFramework="net46" />
 </packages>
\ No newline at end of file