Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vectorized vs circular #4

Open
vanhauser-thc opened this issue May 1, 2020 · 4 comments
Open

vectorized vs circular #4

vanhauser-thc opened this issue May 1, 2020 · 4 comments

Comments

@vanhauser-thc
Copy link

What are the advantages/disadvantages of the vectorized vs circular solution?

Thanks!
@vanhauser-thc
Copy link
Author

vector is much faster than the circular implementation

@adrianherrera
Copy link
Owner

Hey sorry, I completely missed this issue.

I actually haven't done any benchmarking yet, I was going to do it later in the week. Do you have any concrete numbers?

@vanhauser-thc
Copy link
Author

it was 380/s vs 260/s (I used ngram-8, same random numbers, single testcase, running for 4 minutes etc.), repeated twice.

@adrianherrera
Copy link
Owner

Awesome, thanks. I will also do some tests and report back here with some results!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vanhauser-thc @adrianherrera