Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion errors in Ember 3.10 - can be fixed in later ember-macro-helpers version #308

Open
xtagon opened this issue May 30, 2019 · 3 comments

Comments

@xtagon
Copy link

xtagon commented May 30, 2019

Hi,

ember-moment 7.8.1 depends on ember-macro-helpers ^2.1.0, but ember-macro-helpers fixed an Ember 3.10 incompatibility in 3.1.0 and up.

Would it be possible to update ember-moment to use the latest ember-macro-helpers, or loosen the dependency so that either may be allowed?

Thanks!

@enspandi
Copy link

enspandi commented May 30, 2019

Meanwhile you can try to add a resolution to package.json, like:

"resolutions": {
    "ember-macro-helpers": "^4.0.0"
  },

@xtagon
Copy link
Author

xtagon commented May 30, 2019

I'll give it a try.

@xtagon
Copy link
Author

xtagon commented May 30, 2019

Looks like it works - thanks for that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants