Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify this.withVariation usage #408

Open
herzzanu opened this issue Mar 14, 2023 · 1 comment
Open

Clarify this.withVariation usage #408

herzzanu opened this issue Mar 14, 2023 · 1 comment
Assignees
@herzzanu
Labels
documentation question

Comments

@herzzanu
Copy link
Collaborator

It looks like in the docs we're documenting to use async this.withVariation I guess the async is for having the settled in here Do we really need the settled() helper at that point?

@achambers @SkoebaSteve any thoughts?
@herzzanu herzzanu self-assigned this Mar 14, 2023
@SkoebaSteve
Copy link
Collaborator

I havre checked but I don't see a particular reason for this being there. I think we should create a branch removing it and see what impact it has for us, WDYT @herzzanu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herzzanu herzzanu

Labels
documentation question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@herzzanu @SkoebaSteve