-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getting deprecation warning #92
Comments
Looks like https://github.com/hhff/ember-infinity/blob/master/addon/components/infinity-loader.js#L18 and https://github.com/hhff/ember-infinity/blob/master/addon/components/infinity-loader.js#L19 are the culprits. We'd love a PR for this! |
Wrapping the body of didInsertElement() {
this._super(...arguments);
Ember.run.scheduleOnce('afterRender', this, () => {
this._setupScrollable();
this.set('guid', Ember.guidFor(this));
this._bindEvent('scroll');
this._bindEvent('resize');
this._loadMoreIfNeeded();
});
}, This probably isn't an ideal solution as it causes an additional render, but I'm not sure what the ideal solution looks like. See the discussion here: emberjs/ember.js#11493 |
Closing for now. Feel free to open again if somebody notices a problem! |
A property of <frontend@view:-outlet::ember390> was modified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation
Ember 2.0.0
The text was updated successfully, but these errors were encountered: