Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to build with custom electron-prebuilt-compile #388

Closed
jacobq opened this issue Apr 15, 2019 · 3 comments
Closed

How to build with custom electron-prebuilt-compile #388

jacobq opened this issue Apr 15, 2019 · 3 comments

Comments

@jacobq
Copy link
Collaborator

jacobq commented Apr 15, 2019

Anyone get ember-electron to successfully package an app while using an unofficial version of electron-prebuilt-compile (e.g. to use v4.1.4)? I am using a tarball URL, and it almost works. I can run ember electron fine, but when I try to package (ember electron:make ...) I run into problems.

Part of it is because electron-packager (v11 used by electron-forge v5.2.4 used by current ember-electron) expects electron-prebuilt-compile to be specified as a version string (see electron/packager#975). However, even when I fork electron-forge and electron-packager to correct for this, I now get an unexpected Failed to locate module error for things that should just be devDependencies, e.g.:

cleaning up...
Built and assembled Electron project successfully. Stored in "/path/to/app/tmp/package_task-tmp_path-n3SsStVQ.tmp".
Packaging Electron project.
Failed to locate module "@types/ember" from "/path/to/app/tmp/package_task-tmp_path-n3SsStVQ.tmp"

        This normally means that either you have deleted this package already somehow (check your ignore settings if using electron-packager).  Or your module installation failed.


Stack Trace and Error Report: ...
@jacobq jacobq changed the title How to build with custom electron-prebuilt-compile Question: How to build with custom electron-prebuilt-compile Apr 15, 2019
@jacobq jacobq changed the title Question: How to build with custom electron-prebuilt-compile How to build with custom electron-prebuilt-compile Apr 15, 2019
@jacobq
Copy link
Collaborator Author

jacobq commented Apr 15, 2019

I can "work around" this by setting electronPackagerConfig: { prune: false, ... } in electron-forge-config.js, but I've never had to do that before and don't understand why I would now. What part of the code is trying to lookup a module like @types/... / how can I tell / why is it doing that?

@RobbieTheWagner
Copy link
Member

@bendemboski should we close this now that v3 beta is out?

@bendemboski
Copy link
Member

In the 3.0 beta we're on the latest electron-forge which doesn't use electron-prebuilt-compile 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants