Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatefulArray is broken with Ember 2.8. #209

Closed
workmanw opened this issue Aug 22, 2016 · 5 comments
Closed

StatefulArray is broken with Ember 2.8. #209

workmanw opened this issue Aug 22, 2016 · 5 comments

Comments

@workmanw
Copy link
Contributor

workmanw commented Aug 22, 2016

See my comment here: emberjs/ember.js#13534 (comment)

Not sure yet what the best course of action is there. Hopefully we can get a response there and can figure out where to go from there.

Edit: Now an issue open in Ember: emberjs/ember.js#14114.

@workmanw
Copy link
Contributor Author

Just an update, Martin was kind enough to open a PR to help resolve this issue for Ember 2.8: emberjs/ember.js#14117

@jakesjews
Copy link
Contributor

@workmanw glad to hear it! Should we close this issue or will there be some changes we will need to make later?

@workmanw
Copy link
Contributor Author

@jakesjews I'd prefer to leave this issue open until this that PR is merged and ember cuts a new beta ... just incase someone actually tries the ember-beta and runs into this issue.

In terms of making changes, I do think we'll have to make some changes in the near future (post ember 2.8 LTS). But I'll keep a watchful eye on it!

@jakesjews
Copy link
Contributor

@workmanw sounds good. Thanks for looking into the issue.

@workmanw
Copy link
Contributor Author

A new beta version was just released yesterday. Tested with ember try:each and can confirm all tests pass on all supported versions of ember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants