Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken with Ember 3.10.0 #640

Closed
stopfstedt opened this issue May 15, 2019 · 1 comment · Fixed by #641
Closed

Broken with Ember 3.10.0 #640

stopfstedt opened this issue May 15, 2019 · 1 comment · Fixed by #641

Comments

@stopfstedt
Copy link
Contributor

Environment

  • Ember Version: 3.10.0
  • Ember CLI Version: 3.10.0
  • Ember CP Validations Version: 4.0.0-beta.8

Steps to Reproduce

npx ember-cli-update --to=3.10.0
npm install
npm test

Fails with error message: EmberObject.create no longer supports defining computed properties. Define computed properties using extend() or reopen()

refs #635
@GavinJoyce GavinJoyce mentioned this issue May 28, 2019
Merged
@patocallaghan patocallaghan mentioned this issue Aug 21, 2019
Closed
@patocallaghan
Copy link

FYI this issue has started happening again with the Ember 3.13 beta but I have a fix here #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support ember 3.10, drops support for decorators GavinJoyce/ember-cp-validations
2 participants
@patocallaghan @stopfstedt