Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon usage in 9.0.0 #193

Open
miguelcobain opened this issue Sep 4, 2018 · 1 comment
Open

addon usage in 9.0.0 #193

miguelcobain opened this issue Sep 4, 2018 · 1 comment

Comments

@miguelcobain
Copy link

miguelcobain commented Sep 4, 2018

It's not very clear what's the upgrade path for addons that use ember-cli-sass to provide sass styles for the consuming app.

Is it the addon's responsibility to provide a sass implementation?
Should we document and delegate that to the user?

I guess that ideally we would provide a default implementation that the user could override if needed.

@jrjohnson
Copy link

jrjohnson commented Sep 7, 2018

v8.0.1 which followed 9.0.0 now auto uses dart-sass https://github.com/aexmachina/ember-cli-sass/blob/master/index.js#L36 so I think my approach is going to be to put sass into my dependencies for my addon which will provide to to consuming apps and be available as the default.

I don't know if this is the best approach, but it's the only one I can think of 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants