Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sassOptions should be moved to your ember-cli-build" deprecation warning should be removed #171

Open
minusfive opened this issue Oct 19, 2017 · 3 comments

Comments

@minusfive
Copy link

When used as a nested addon, and sassOptions are passed through the config() addon hook, this deprecation warning is still shown, even though it seems like the correct way of doing it, no?

@simonexmachina
Copy link
Collaborator

I'm not working with Ember at the moment, so I can't really say. PRs are welcome though. @stefanpenner might be able to advise?

@deanpapastrat
Copy link

Wanted to bring this back up; I'm using this in a nested addon as well, and there's no way around it. I can ignore the warning for now, but I'd like for it to be considered "officially ok" behavior :)

@hilljh82
Copy link

@deanpapastrat I agree. I am the author of ember-cli-mdc. One of the reasons I wrote my own sass wrapper for ember-cli-mdc several years ago was because of this very issue. I have decided to migrate back to ember-cli-sass, and this behavior still exists. It would be great if this warning could be removed when using ember-cli-sass from within an add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants