-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select does not propagate change event #6217
Comments
Thanks for the issue and initial digging, I think your solution could work. |
@snowystinger i've already patched this in my project, I could start a PR if you want. |
We are having the same issue with other form elements including |
This one also seems to be the same issue: #5955 |
After some testing I think the proposed solution will only work for components using a hidden I tested workaround/solutions from the following issues without success (using react through next.js):
|
Checkbox/Radio is probably a different issue, looks like we stop propagation on both of those, https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/toggle/src/useToggle.ts#L56 |
Hey! I wanted to add that my team is also experiencing this issue. As a temporary measure, we have "hacked" a workaround in our codebase that submits a native Could you provide an update on the status of this issue? Thanks in advance 😃 |
Provide a general summary of the issue here
When you change a value in a Select element there is no change event that bubbles causing patterns like
<form onChange>
to stop working.🤔 Expected Behavior?
The select should trigger a change event like normal form elements.
😯 Current Behavior
The
<Select>
element does not behave like a native<select>
element by not bubbling change events.💁 Possible Solution
I believe the reason why this currently does not work is because the select just get's re-rendered. Maybe adding a manual change event in the
<HiddenSelect>
would solve this.🔦 Context
No response
🖥️ Steps to Reproduce
https://codesandbox.io/p/sandbox/twilight-voice-tjmwcl?file=%2Fsrc%2FApp.js%3A4%2C9
Version
1.0.0-rc.0
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
If other, please specify.
No response
What operating system are you using?
macOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response
The text was updated successfully, but these errors were encountered: