Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group aria component is not disabling children button #5637

Open
federicocappellotto97 opened this issue Dec 28, 2023 · 1 comment
Open

Group aria component is not disabling children button #5637

federicocappellotto97 opened this issue Dec 28, 2023 · 1 comment

Comments

@federicocappellotto97
Copy link

Provide a general summary of the issue here

πŸ€” Expected Behavior?

Button should has disabled attribute

😯 Current Behavior

Now only the input get the attribute

πŸ’ Possible Solution

No response

πŸ”¦ Context

No response

πŸ–₯️ Steps to Reproduce

Create a component with the html specified above

Version

"react-aria": "^3.31.0", "react-aria-components": "^1.0.0",

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac OS

🧒 Your Company/Team

No response

πŸ•· Tracking Issue

No response

@yihuiliao
Copy link
Member

Correct me if I am wrong, but I believe what you are trying to do is the following: https://codesandbox.io/s/peaceful-river-nys28q?file=/src/App.js where the expectation is that if isDisabled is applied to <Group> that it would also be passed to its children.

I think Group was really more intended to support interactive states for styling so it doesn't currently pass down these states to its children. For now, if you wanted a disabled button within a group, you would also have to apply isDisabled directly onto the button.

Maybe this is something we can consider implementing in the future since I can see how this would be confusing but I’d like to discuss with the team first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants