Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard pressing does not trigger submit event for a button inside a form. #1593

Closed
deebov opened this issue Feb 17, 2021 · 7 comments · Fixed by #904
Closed

Keyboard pressing does not trigger submit event for a button inside a form. #1593

deebov opened this issue Feb 17, 2021 · 7 comments · Fixed by #904
Assignees

Comments

@deebov
Copy link
Contributor

deebov commented Feb 17, 2021

😯 Current Behavior

Pressing the space or enter key does not trigger a submit event for type="submit" button inside a form. However, it does trigger the onPress action on button which makes it really confusing.

🤔 Expected Behavior

Pressing the space or enter key should trigger a submit event for type="submit" button inside a form.

💻 Code Sample

https://codesandbox.io/s/weathered-silence-eqr18?file=/src/App.tsx

🌍 Your Environment

Software Version(s)
react-spectrum 3.3.0
@snowystinger
Copy link
Member

This may be relevant #904

@deebov
Copy link
Contributor Author

deebov commented Feb 18, 2021

The PR seems to be stale. Is there any intention to merge and release it any soon?

@snowystinger
Copy link
Member

it stalled because there was no one asking for it, so now it should get some tlc again

@deebov
Copy link
Contributor Author

deebov commented Feb 19, 2021

is there anything I can do to speed up the process?

@snowystinger
Copy link
Member

snowystinger commented Feb 22, 2021

Thank you for your offer, the team wants to go over a few options so we'll be making time for it in the next sprint.
In the meantime, you could try patching it in the way outlined in the PR, though I don't remember the state of it, so it might require a bit of testing on your end.

@deebov
Copy link
Contributor Author

deebov commented Feb 22, 2021

thanks for the info!

@stefanprobst
Copy link
Contributor

hi, what's the status of this?

@LFDanLu LFDanLu linked a pull request May 19, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants