Skip to content

Commit d5f1280

Browse files
reidbarberLFDanLu
andauthored
docs: S2 docs high priority fixes from testing (#9220)
* fix skeleton title for index page * remove Home link from Overview section * convert relative links in markdown from .html links to .md * fix card logo centering in Safari * add homepage links to mobile header * fix blog video props to match originals * improve search sections * refine "All" tag display logic * fix missing 'client side routing guides' and 'framework setup guides' links * don't clear search field before navigation * remove useEffects * keep 'All' tag after its added * fix extra newline in code output * add comment * Merge remote-tracking branch 'origin/main' into s2-docs-testing-followup-high-priority --------- Co-authored-by: Daniel Lu <[email protected]>
1 parent ef3ff3d commit d5f1280

34 files changed

+123
-76
lines changed
Lines changed: 2 additions & 7 deletions
Loading
Lines changed: 3 additions & 8 deletions
Loading
Lines changed: 4 additions & 9 deletions
Loading

packages/dev/s2-docs/pages/index.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ export default Layout;
44

55
export const section = 'Getting started';
66
export const hideNav = true;
7+
export const hideFromSearch = true;
78

89
<WelcomeHeader />
910

packages/dev/s2-docs/pages/react-aria/GridList.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ function AsyncLoadingExample() {
413413

414414
### Links
415415

416-
Use the `href` prop on a `<GridListItem>` to create a link. See the **client side routing guide** to learn how to integrate with your framework. Link interactions vary depending on the selection behavior. See the [selection guide](selection.html?component=GridList#selection-behavior) for more details.
416+
Use the `href` prop on a `<GridListItem>` to create a link. See the [framework setup guide](frameworks.html) to learn how to integrate with your framework. Link interactions vary depending on the selection behavior. See the [selection guide](selection.html?component=GridList#selection-behavior) for more details.
417417

418418
```tsx render docs={docs.exports.GridList} links={docs.links} props={['selectionBehavior']} initialProps={{'aria-label': 'Links', selectionMode: 'multiple'}} wide
419419
"use client";

packages/dev/s2-docs/pages/react-aria/ListBox.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ function AsyncLoadingExample() {
193193

194194
### Links
195195

196-
Use the `href` prop on a `<ListBoxItem>` to create a link. See the **client side routing guide** to learn how to integrate with your framework.
196+
Use the `href` prop on a `<ListBoxItem>` to create a link. See the [framework setup guide](frameworks.html) to learn how to integrate with your framework.
197197

198198
By default, link items in a ListBox are not selectable, and only perform navigation when the user interacts with them. However, with `selectionBehavior="replace"`, items will be selected when single clicking or pressing the <Keyboard>Space</Keyboard> key, and navigate to the link when double clicking or pressing the <Keyboard>Enter</Keyboard> key.
199199

packages/dev/s2-docs/pages/react-aria/Menu.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ import {Button} from 'vanilla-starter/Button';
281281

282282
### Links
283283

284-
Use the `href` prop on a `<MenuItem>` to create a link. See the **client side routing guide** to learn how to integrate with your framework.
284+
Use the `href` prop on a `<MenuItem>` to create a link. See the [framework setup guide](frameworks.html) to learn how to integrate with your framework.
285285

286286
```tsx render hideImports
287287
"use client";

packages/dev/s2-docs/pages/react-aria/Table.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ function AsyncSortTable() {
256256

257257
### Links
258258

259-
Use the `href` prop on a `<Row>` to create a link. See the **client side routing guide** to learn how to integrate with your framework. Link interactions vary depending on the selection behavior. See the [selection guide](selection.html) for more details.
259+
Use the `href` prop on a `<Row>` to create a link. See the [framework setup guide](frameworks.html) to learn how to integrate with your framework. Link interactions vary depending on the selection behavior. See the [selection guide](selection.html) for more details.
260260

261261
```tsx render docs={docs.exports.ListBox} links={docs.links} props={['selectionBehavior']} initialProps={{'aria-label': 'Bookmarks', selectionMode: 'multiple'}} wide
262262
"use client";

packages/dev/s2-docs/pages/react-aria/Tabs.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ function Example() {
176176

177177
### Links
178178

179-
Use the `href` prop on a `<Tab>` to create a link. See the **client side routing guide** to learn how to integrate with your framework. This example uses a simple hash-based router to sync the selected tab to the URL.
179+
Use the `href` prop on a `<Tab>` to create a link. See the [framework setup guide](frameworks.html) to learn how to integrate with your framework. This example uses a simple hash-based router to sync the selected tab to the URL.
180180

181181
```tsx render
182182
"use client";

packages/dev/s2-docs/pages/react-aria/TagGroup.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ function Example() {
7676

7777
### Links
7878

79-
Use the `href` prop on a `<Tag>` to create a link. See the **client side routing guide** to learn how to integrate with your framework.
79+
Use the `href` prop on a `<Tag>` to create a link. See the [framework setup guide](frameworks.html) to learn how to integrate with your framework.
8080

8181
```tsx render
8282
"use client";

0 commit comments

Comments
 (0)