Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Right-clicking randomly deletes text from the editor #11142

Closed
JordanTheriault opened this issue May 19, 2015 · 19 comments
Closed

Right-clicking randomly deletes text from the editor #11142

JordanTheriault opened this issue May 19, 2015 · 19 comments

Comments

@JordanTheriault
Copy link

Right-clicking on elements or properties will delete the text from the editor. After bisection by @humphd it's determined this is a recent regression caused by a recent commit

@humphd: I bisected, and this was caused by a0daa3a upstream.

Here is a screen cap of it happening.
randomdeletion

@abose
Copy link
Contributor

abose commented May 19, 2015

Looks like a codemirror upstream issue.
@prafulVaishnav @marcelgerber

@marcelgerber
Copy link
Contributor

Ouch.
codemirror/codemirror5@5d8347d is the upstream culprit.
Let's see if it's our fault or theirs.

@marcelgerber
Copy link
Contributor

Because I might not be able to file these today, I sum up my findings here:
It looks like the content of the hidden textarea changes, which is then picked up by slowPoll.

I verified this is not a Chrome-only bug by successfully reproducing this in Brackets, Bracketron and Bramble with both Chrome and Firefox.

@marcelgerber
Copy link
Contributor

That's what the stack trace looks like, with the downright nonsensical call to applyTextInput in the console below.

image

@marcelgerber
Copy link
Contributor

Upstream CM bug filed: codemirror/codemirror5#3273

@marcelgerber
Copy link
Contributor

This is now fixed.
Thanks for reporting!

@ghost
Copy link

ghost commented Jun 2, 2015

Hi!

How can I fix that issue on my end? My brackets is updated but I'm still getting that bug when I right click a text.

@marcelgerber
Copy link
Contributor

Please call git submodule sync && git submodule update --init.

@ghost
Copy link

ghost commented Jun 2, 2015

I'm new to this sorry... where will I call that?

@marcelgerber
Copy link
Contributor

I guess you have a cloned version of Brackets (Is that what "updated" is for you? If not, you shouldn't ever experience this issue with a Release build).
If you have, just navigate in there cd xyz/brackets and then call the two commands from above.

@ghost
Copy link

ghost commented Jun 2, 2015

I navigated in there and typed the two commands but it gives error "no git repository,..."

I have no idea if this one is cloned or not. I just downloaded it here http://brackets.io/ and installed Code Folding plugin.

@marcelgerber
Copy link
Contributor

In that case, you don't have a clone.

So you're saying you see this exact issue in Release 1.3?

@ghost
Copy link

ghost commented Jun 2, 2015

I think yes. check the GIF's below

random_delete_text_on_right_click
pluginsbracket-random_delete_text_on_right_click

@marcelgerber
Copy link
Contributor

Indeed. Could you just quickly try Debug > Reload without extensions?

@ghost
Copy link

ghost commented Jun 2, 2015

same problem..

@ghost
Copy link

ghost commented Jun 2, 2015

oh wait.. Without you say? yes it's not deleting anymore when Reload without extensions

@mackenza
Copy link
Contributor

mackenza commented Jun 2, 2015

it would be good to get a list of your extensions then as it seems to be an extension issue.

@abose
Copy link
Contributor

abose commented Jun 2, 2015

The first GIF shows that it is the release build;Did you correctly launch brackets from the sources at the time?

@marcelgerber
Copy link
Contributor

@mackenza You can see them in the second GIF:

  • Code Folding (the one that is now a default extension)
  • Extract for Brackets
  • FunctionFinder
  • Smooth Scroll

@abose The thing is, he runs into this issue with his Release build (but caused by some extension).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants
@redmunds @mackenza @marcelgerber @abose @JordanTheriault and others