Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for U+2326 ⌦ #153

Closed
LilianValero opened this issue Nov 19, 2018 · 11 comments
Closed

Add support for U+2326 ⌦ #153

LilianValero opened this issue Nov 19, 2018 · 11 comments

Comments

@LilianValero
Copy link

Hi, it seems that the delete MAC glyph is not rendered correctly in the v2.0.40. May you confirm, please?
With the v2.040, we have:
delete_item
delete_rule
Basically, we should have:
fixed_delete_item

@frankrolf
Copy link
Member

I assume you are talking about ⌫ U+232B, and I don’t think this glyph has ever been supported in Source Sans Pro.
You can find fonts which support that glyph here: https://www.fileformat.info/info/unicode/char/232b/fontsupport.htm

@miguelsousa
Copy link
Member

Related to #97
Support for ⌫ U+232B was added in v2.040, in the upright fonts at least. Is it not there?

@LilianValero
Copy link
Author

Yes it seems that upleft MAC glyph is there but not the upright MAC glyph.

@LilianValero
Copy link
Author

Do you think that we can add someday the upright, please?

@frankrolf
Copy link
Member

frankrolf commented Nov 20, 2018

Oof, I apologize. I wasn’t aware of the addition and looked at an outdated file.
However I can see the glyphs in the latest version of Source Sans Pro Regular:
screen shot 2018-11-20 at 09 20 23

@LilianValero
Copy link
Author

yes but not the upright which corresponds to the DEL command.

@frankrolf
Copy link
Member

Upright in this context means “not Italic”, and does not describe the shape of the glyph.
Please clarify which glyph you are talking about by referring to a code point.

@LilianValero
Copy link
Author

We'd like to use the upright:
delete glyph
for delete actions of our application.
It seems that the upright are used by other applications like IntelliJ to delete items.

@frankrolf
Copy link
Member

It always is easier to communicate using code points upfront – if you mean U+2326 ⌦, then my original statement is true: This character has not been supported in Source Sans Pro.
It would be simple enough to add the glyph, however I’ll leave this decision to @pauldhunt.

FYI – upright does not mean right-pointing. Upright means “Roman, not Italic“.

@frankrolf frankrolf reopened this Nov 20, 2018
@LilianValero
Copy link
Author

Thks to investigate and sorry for the confusion.

@miguelsousa miguelsousa changed the title Delete MAC glyph not supported in v2.0.40 Add support for U+2326 ⌦ Jan 11, 2019
@erniemarch
Copy link

confirmed in both roman and italic 3.006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants