fix(tests): atualizar imports de hooks movidos para subpastas#20
Merged
Conversation
3 testes de smoke em tests/hooks/ estavam quebrando com 'Failed to resolve import' no CI (job 76823255050, run 26121173456) porque referenciavam paths antigos de hooks que foram movidos para subpastas em commits 4df6ecf e 95bac00 (ambos de 19/mai). Imports corrigidos: - @/hooks/useComparisonSync -> @/hooks/comparison/useComparisonSync - @/hooks/usePrintAreas -> @/hooks/simulation/usePrintAreas - @/hooks/productsCustomizationOptions-> @/hooks/products/useProductCustomizationOptions (o terceiro tinha um typo adicional: faltava 'use' no inicio do path e o 's' de products estava plural — o nome correto do hook exportado e' useProductCustomizationOptions e fica em src/hooks/products/.) Validacao local (mesma versao de Node do CI, v20.20.2): npx vitest run \ tests/hooks/catalog-comparison-smoke.test.ts \ tests/hooks/usePrintAreas.smoke.test.ts \ tests/hooks/useProductCustomizationOptions.smoke.test.ts Resultado: 3 test files / 6 tests passed (309ms tests, 9.11s total). Refs: run 26121173456 / job 76823255050
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughO PR atualiza três testes de smoke para importar hooks a partir de novos caminhos, refletindo uma reorganização de estrutura de pastas: ChangesReorganização de imports de hooks
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR corrige falhas de resolução de imports em smoke tests de hooks após os hooks terem sido movidos para subpastas em src/hooks/, alinhando os paths usados nos testes com a localização real dos módulos.
Changes:
- Atualiza o import de
useComparisonSyncpara@/hooks/comparison/useComparisonSync. - Atualiza o import de
usePrintAreaspara@/hooks/simulation/usePrintAreas. - Corrige o import de
useProductCustomizationOptionspara@/hooks/products/useProductCustomizationOptions(incluindo o typo pré-existente no path antigo).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/hooks/catalog-comparison-smoke.test.ts | Ajusta import do hook de comparação para a nova subpasta (comparison/). |
| tests/hooks/usePrintAreas.smoke.test.ts | Ajusta import do hook de simulação para a nova subpasta (simulation/). |
| tests/hooks/useProductCustomizationOptions.smoke.test.ts | Ajusta import do hook de produtos para a nova subpasta (products/) corrigindo o path antigo incorreto. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
4 tasks
adm01-debug
added a commit
that referenced
this pull request
Jun 4, 2026
…644) Auditoria exaustiva do módulo de catálogo — correções seguras e isoladas: 1. useProductImages.fetchProductImagesBatch: usa filtro IN(product_id) em chunks (80) em vez de baixar a tabela product_images inteira (limit 5000) e filtrar em memória — evita transferir milhares de linhas e o truncamento silencioso pelo teto de limit. 2/14/26. product-sorting: comparador único compareNamePtBR (Intl.Collator pt-BR, numeric + sensitivity base) — "Caneta 2" antes de "Caneta 10", acentuação consistente. Tie-break por id em todos os modos → ordem determinística entre páginas no infinite scroll. Aliases name-asc/ name-desc tratados explicitamente (antes caíam no no-op default), tanto no sorter quanto no orderBy server-side do productService. 4/28. useFiltersPageState: valida priceRange e minStock vindos da URL (NaN guard + clamp min<=max) — antes ?priceMin=abc zerava a lista sem feedback. sortBy da URL só é aceito se for um valor conhecido. 20. useFiltersPageState: filtro de Técnicas só conta como ativo / exibe chip / filtra quando há metadata.techniques nos produtos. Antes era um no-op que ainda contava no badge e mostrava chip (falso positivo). 5/10. Migração add_catalog_sort_indexes: índices parciais (WHERE active) para sale_price, created_at DESC e stock_quantity DESC — colunas de ordenação do catálogo que não tinham índice. Já aplicada no projeto. Testes unitários adicionados para o collator pt-BR, aliases de nome e tie-break determinístico. Gates TSC (0 erros) e ESLint baseline (0) verdes. https://claude.ai/code/session_01E14WrLRzQUQpeRs9sFV2uk Co-authored-by: Claude <noreply@anthropic.com>
adm01-debug
added a commit
that referenced
this pull request
Jun 5, 2026
* perf(catalog): quick wins da auditoria do catálogo (#1,#2,#4,#5,#20) Auditoria exaustiva do módulo de catálogo — correções seguras e isoladas: 1. useProductImages.fetchProductImagesBatch: usa filtro IN(product_id) em chunks (80) em vez de baixar a tabela product_images inteira (limit 5000) e filtrar em memória — evita transferir milhares de linhas e o truncamento silencioso pelo teto de limit. 2/14/26. product-sorting: comparador único compareNamePtBR (Intl.Collator pt-BR, numeric + sensitivity base) — "Caneta 2" antes de "Caneta 10", acentuação consistente. Tie-break por id em todos os modos → ordem determinística entre páginas no infinite scroll. Aliases name-asc/ name-desc tratados explicitamente (antes caíam no no-op default), tanto no sorter quanto no orderBy server-side do productService. 4/28. useFiltersPageState: valida priceRange e minStock vindos da URL (NaN guard + clamp min<=max) — antes ?priceMin=abc zerava a lista sem feedback. sortBy da URL só é aceito se for um valor conhecido. 20. useFiltersPageState: filtro de Técnicas só conta como ativo / exibe chip / filtra quando há metadata.techniques nos produtos. Antes era um no-op que ainda contava no badge e mostrava chip (falso positivo). 5/10. Migração add_catalog_sort_indexes: índices parciais (WHERE active) para sale_price, created_at DESC e stock_quantity DESC — colunas de ordenação do catálogo que não tinham índice. Já aplicada no projeto. Testes unitários adicionados para o collator pt-BR, aliases de nome e tie-break determinístico. Gates TSC (0 erros) e ESLint baseline (0) verdes. https://claude.ai/code/session_01E14WrLRzQUQpeRs9sFV2uk * fix(filters): add onSale chip + silence exhaustive lint regressions from main - useFiltersPageState: onSale was counted in activeFiltersCount but had no corresponding chip in activeFiltersSummary — users could not remove it via the removable-filter UI. Added "Em Oferta / Sim" summary entry. - ProductCard, useMobileSidebarFix: add eslint-disable-next-line for react-hooks/exhaustive-deps where omission is intentional (granular deps vs whole object; route-change-only trigger). - ThemeInitializer.test, useCatalogPrefetch.test: add eslint-disable-next-line for no-explicit-any on vitest mock casts (standard test-mocking pattern). All 4 files were introduced by main-branch commits after the baseline was generated; these suppress the regressions without changing runtime behavior. https://claude.ai/code/session_01E14WrLRzQUQpeRs9sFV2uk --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Job 76823255050 (
Hook tests — Smoke tests (hooks)) falhou nomaincomFailed Suites 3:Diagnóstico
Os hooks existem, mas foram movidos para subpastas hoje (19/mai), sem que os testes correspondentes fossem atualizados:
useComparisonSync@/hooks/useComparisonSyncsrc/hooks/comparison/useComparisonSync.ts4df6ecfusePrintAreas@/hooks/usePrintAreassrc/hooks/simulation/usePrintAreas.ts95bac00useProductCustomizationOptions@/hooks/productsCustomizationOptionssrc/hooks/products/useProductCustomizationOptions.tsuseeproductsestava plural)Verificado: exports continuam idênticos (
export function useComparisonSync,export function usePrintAreas,export function useProductCustomizationOptions) — só os paths mudaram.Solução
Atualizar os 3 imports nos arquivos de teste. Não alterar nada em
src/, nada em workflows, nada em config.Mudança
tests/hooks/:catalog-comparison-smoke.test.ts(1 linha)usePrintAreas.smoke.test.ts(1 linha)useProductCustomizationOptions.smoke.test.ts(1 linha)Validação local
Refs: run 26121173456 / job 76823255050
Summary by cubic
Updated three smoke test imports to match the new hook subfolder paths, fixing import resolution errors in CI. No app code changes; tests pass.
@/hooks/useComparisonSync->@/hooks/comparison/useComparisonSync@/hooks/usePrintAreas->@/hooks/simulation/usePrintAreas@/hooks/productsCustomizationOptions->@/hooks/products/useProductCustomizationOptionsWritten for commit dc9fb1d. Summary will update on new commits. Review in cubic
Summary by CodeRabbit