fix(qa): full QA sprint — 337 TS errors → 0, 11 bugs, 105+ tests [rebased onto main]#619
Merged
Merged
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 17 minutes and 54 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (90)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Fix ProductCard variable-before-declaration bug (P1 runtime crash risk) - Fix ProductGrid colors type mismatch (undefined vs required array) - Fix ProductStatusBadge unreachable "out-of-stock" case branches - Fix ProductCardImage urgency type mismatches - Fix NoveltyCards wrong property paths (product.product → flat access) - Fix NoveltiesSection/NoveltyStatsCards query data type casts - Fix VirtualizedNoveltyGrid missing onClick prop - Fix NoveltyProductGrid Set→Array conversion - Fix ExternalCollectionCard missing icon_color type - Fix AdvancedSearch SearchResult type mismatch - Fix GlobalCommandBar theme type narrowing - Fix NotificationDrawer DateRange handler type - Fix NotificationPreferences missing required fields - Fix useProductsManager/useSuppliersManager dbInvokeDelete signature - Fix ProductMarketingSection Supabase update type via untypedFrom - Fix mockupGenerationService missing singleUrl/batchResults on result type - Fix useMockupGenerator downloadMockupAsPdf argument shape - Fix useProfileRoles missing await on getSupabaseClient() - Migrate 20+ hooks from supabase.from() to untypedFrom() for ungenerated tables - Create missing dev modules (BridgeMetricsOverlay, MetricUtils, useBridgeMetrics) - Remove unused Loader2 import from QuotesListPage - Fix SidebarNavGroup test mock typing - Fix PdfGenerationModule test mock typing - Create QA baseline, recon report, test matrix, and 11 bug reports https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
- Fix ProductGrid: move useMemo/useEffect hooks before early returns (rules-of-hooks P0) - Fix useSparklineSales: replace != with !== for strict equality - Fix CatalogContent: remove unused useEffect import and dev console.log - Fix ScrollProgress: remove unused useState/forwardRef/useCallback imports - Update ESLint baseline to reflect current state https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
Batch migration of supabase.from() to untypedFrom(), BatchQuery/BatchResult to InvokeOptions/InvokeResult, missing imports, type union additions, and type narrowing fixes. Source files now have zero TypeScript errors. https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
- 7 regression tests covering BUG-001 through BUG-011 (structural invariants) - 20 security header tests validating CSP, HSTS, X-Frame-Options, etc. - QA final report with KPIs, bug summary, and recommendations All 27 new tests pass. Combined with existing RLS tests (46) and store tests (16+), total validated coverage is 105+ tests. https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
- useProductInsights: restore supabase.from('orders') with rls-allow annotation
to preserve seller-scope checker (Copilot)
- useNovelties: migrate to untypedFrom, fix 410 fallback paths that threw
instead of degrading gracefully (Copilot, Codex)
- useBridgeMetrics: connect to actual bridgeCallMetrics telemetry via
useSyncExternalStore, fix clear() no-op (Copilot, Codex)
- DevOnlyBridgeOverlay: gate rendering behind useDevGate isDev check (Codex)
- useProfileRoles: map queryRoles rows from {role: string} to string[] (Codex)
- mockupGenerationService: populate singleUrl from mockupUrl (Codex)
- technique.repository: replace double cast with explicit field mapping (Copilot)
- NotificationPreferences: replace optimistic update with loadPreferences (Copilot)
- RELATORIO_FINAL: fix P0-P1 count (8→11 total) and regression test count (27→7)
https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
- EnhancedProductCard: separate out-of-stock from limited-stock urgency badge - NoveltyProductGrid: restore product click navigation in non-selection mode - MetricUtils: fix formatBytes out-of-bounds for values >= 1TB, add TB unit - useCatalogState: remove 3 console.log statements from production hook - BUG-008.md: correct bug report content to match downloadMockupAsPdf issue https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
- Fix useSyncExternalStore snapshot pattern: getBridgeSamples now returns immutable snapshot copy instead of mutable array reference (identified by cubic) - Fix NotificationPreferences: optimistic local update without loading flicker - Fix technique.repository.ts: minCores uses 1 when permiteCores is true, timestamps use dados_extras or stable epoch fallback (identified by cubic) - Fix BridgeMetricsOverlay: add toggle button when closed, close button when open (identified by Codex) https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
… fixes Adds Phases 4-9 scan results (all clean), Phase 11 delivery status, and 13 additional bugs fixed during 4 rounds of code review. https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
When a user toggles a category not yet in their preferences array, the optimistic update now appends a new entry instead of silently doing nothing. https://claude.ai/code/session_01FrYqF7meHvAWfa4V1XWG7T
adm01-debug
force-pushed
the
claude/loving-thompson-nPmxc-rebase
branch
from
5cdbe0c to
f260b12
Compare
This was referenced Jun 2, 2026
adm01-debug
added a commit
that referenced
this pull request
Jun 2, 2026
Implements the CI gate recommended in QA sprint (PR #619). Blocks PRs that introduce TS regressions or ESLint baseline violations. Gates: tsc-baseline, lint:baseline, vite build, vitest unit tests.
Contributor
There was a problem hiding this comment.
Pull request overview
Large QA-sprint rebase that aims to eliminate TypeScript drift/regressions, standardize Supabase access patterns (notably via untypedFrom/dbInvoke), and add regression/security tests to prevent previously fixed issues from reappearing.
Changes:
- Migrates many PostgREST reads/writes away from typed
supabase.from()tountypedFrom()/dbInvoke()to resolve schema/type drift. - Adds/updates Vitest suites for security headers and QA regression invariants.
- Introduces dev-only bridge telemetry overlay + stabilizes
useSyncExternalStoresnapshot behavior.
Reviewed changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/security/security-headers.test.ts | New Vitest assertions for required Vercel security headers/CSP. |
| tests/regression/qa-cycle-bugfixes.test.ts | New structural regression tests for key QA bugfixes (hooks order, TDZ, drift). |
| src/types/product-catalog.ts | Extends ProductFilters with sortBy. |
| src/pages/quotes/QuotesListPage.tsx | Removes unused icon import. |
| src/lib/telemetry/bridgeCallMetrics.ts | Adds immutable snapshot for useSyncExternalStore consumption + new op. |
| src/lib/query-config.ts | Adjusts React Query option mutation via cast to satisfy typing. |
| src/lib/personalization/repositories/technique.repository.ts | Reworks external→unified technique mapping + stable timestamps. |
| src/lib/notifications-metrics.ts | Adds filter-change fetch source and metrics bucket. |
| src/lib/external-db/products.ts | Aligns “batch” query typing to dbInvoke options/results + operation fields. |
| src/lib/external-db/products-detail.ts | Aligns enrichment query typing to dbInvoke options + operation fields. |
| src/lib/external-db-prewarm.ts | Uses untypedFrom for prewarm selects. |
| src/lib/db/postgrest.ts | Switches dbInvoke/dbInvokeDelete reads/writes to untypedFrom. |
| src/lib/cloud-status.ts | Wraps thenable query with Promise.resolve for timeout helper typing. |
| src/hooks/useNavigationAnalytics.ts | Uses untypedFrom for navigation analytics insert. |
| src/hooks/ui/useWorkspaceNotifications.tsx | Uses untypedFrom for notification fetch/count queries. |
| src/hooks/simulation/useTechniquePricingOptions.ts | Tightens setState typing for price tables. |
| src/hooks/simulation/useTechniquePricing.ts | Uses untypedFrom for pricing table fetch. |
| src/hooks/simulation/useSimulation.ts | Uses untypedFrom for personalization simulations CRUD. |
| src/hooks/simulation/usePrintAreas.ts | Uses untypedFrom, adds shape typing cast. |
| src/hooks/simulation/useGravacaoV2.ts | Uses untypedFrom for engraving pricing queries. |
| src/hooks/simulation/useExternalSimulator.ts | Adjusts local dbInvoke count typing to `number |
| src/hooks/quotes/useQuoteBuilderState.ts | Cast tweak for contact_id extraction. |
| src/hooks/products/useSupplierNames.ts | Updates supplier name fetch to InvokeOptions/dbInvoke. |
| src/hooks/products/useSupplierFiscalData.ts | Migrates multiple tables to untypedFrom. |
| src/hooks/products/useProductSupplierSources.ts | Uses untypedFrom for dynamic-table insert/update/delete paths. |
| src/hooks/products/useProductsLightweight.ts | Narrows countMode literal typing. |
| src/hooks/products/useProductsColorsBatch.ts | Uses untypedFrom + filters mock IDs via UUID regex. |
| src/hooks/products/useProductInsights.ts | Migrates several reads to untypedFrom while keeping seller-scope checked query typed. |
| src/hooks/products/useNovelties.ts | Uses untypedFrom(resolveTable) helper + improves error fallbacks/casts. |
| src/hooks/products/useColorSystem.ts | Uses untypedFrom for nuances fetch. |
| src/hooks/products/useColorEnrichment.ts | Migrates ref + variant/image loads to dbInvoke result shape. |
| src/hooks/products/useCatalogState.ts | Trivial formatting change. |
| src/hooks/products/useCatalogPrefetch.ts | Narrows countMode literal typing. |
| src/hooks/mockup/useMockupGenerator.ts | Fixes downloadMockupAsPdf argument shapes + null fallback. |
| src/hooks/mockup/mockupGenerationService.ts | Uses untypedFrom for inserts; extends GenerateMockupResult shape. |
| src/hooks/intelligence/useSparklineSales.tsx | Replaces loose equality check with strict null/undefined check. |
| src/hooks/intelligence/useSalesGoals.ts | Uses untypedFrom for sales goals CRUD. |
| src/hooks/gravacao/useTecnicasGravacao.ts | Uses untypedFrom for engraving table CRUD + count guards. |
| src/hooks/dev/useBridgeMetrics.ts | New hook consuming bridge telemetry store via useSyncExternalStore. |
| src/hooks/collections/useExternalCollections.ts | Uses untypedFrom + extends ExternalCollection shape with icon_color. |
| src/hooks/auth/useProfileRoles.ts | Awaits lazy supabase client; uses queryRoles; maps role rows to AppRole[]. |
| src/hooks/auth/useAccessSecurity.ts | Uses untypedFrom for access security tables. |
| src/hooks/auth/use2FA.ts | Uses untypedFrom for 2FA settings reads/writes (removes raw client cast). |
| src/hooks/admin/useGeoBlocking.ts | Uses untypedFrom for geo/security settings + countries. |
| src/hooks/admin/useDeviceDetection.ts | Uses untypedFrom for known devices CRUD. |
| src/hooks/admin/useAllowedIPs.ts | Uses untypedFrom for allowlist CRUD. |
| src/components/ui/sonner.tsx | Theme narrowing via cast to satisfy component prop typing. |
| src/components/search/GlobalSearchPalette.tsx | Adds explicit cast for popular products list shape. |
| src/components/search/AdvancedSearch.tsx | Narrows visual search callback type to explicit product shape. |
| src/components/products/ProductStatusBadge.tsx | Adds 'out-of-stock' to union + renders with icon. |
| src/components/products/ProductGrid.tsx | Forces colors to [] while hydrating, types enriched product. |
| src/components/products/ProductCardImage.tsx | Removes unreachable stock status branch; normalizes urgency badge props. |
| src/components/products/ProductCard.tsx | Hoists allMatchingVariants before effect dependencies to avoid TDZ. |
| src/components/products/EnhancedProductCard.tsx | Aligns props/fields to Product shape and fixes badges/quantity fields. |
| src/components/pdf/tests/PdfGenerationModule.test.ts | Casts DOM spy implementations to satisfy typing. |
| src/components/novelties/VirtualizedNoveltyGrid.tsx | Fixes click/select behavior regression in selection vs navigation modes. |
| src/components/novelties/NoveltyStatsCards.tsx | Casts hook return type for stats rendering. |
| src/components/novelties/NoveltyProductGrid.tsx | Unifies selection/navigation callback for table view. |
| src/components/novelties/NoveltyCards.tsx | Fixes property paths (flat novelty record) + stable row keys + onSelect. |
| src/components/novelties/NoveltiesSection.tsx | Casts novelty stats hook return type. |
| src/components/novelties/tests/NoveltyProductGrid.integration.test.tsx | Adjusts testing-library imports. |
| src/components/notifications/NotificationPreferences.tsx | Avoids .find() object reuse; uses .some() to prevent reload flicker path. |
| src/components/notifications/NotificationDrawer.tsx | Guards Calendar range handler typing. |
| src/components/mockup/approval/OffscreenLayoutCapture.tsx | Uses untypedFrom for generated mockups update. |
| src/components/layout/sidebar/tests/SidebarNavGroup.shortcut-carrinhos.test.tsx | Tightens vi.fn typing for navigate mock. |
| src/components/dev/metrics/MetricUtils.ts | New helpers for latency class + bytes formatting. |
| src/components/dev/DevOnlyBridgeOverlay.tsx | New dev-gated lazy overlay wrapper. |
| src/components/dev/BridgeMetricsOverlay.tsx | New overlay UI with toggle button. |
| src/components/common/ScrollProgress.tsx | Adds new imports (currently unused). |
| src/components/command/GlobalCommandBar.tsx | Forces theme-setting action to always choose dark (matches ThemeContext). |
| src/components/catalog/CatalogContent.tsx | Reverts view components to static imports + adds diagnostic counter. |
| src/components/admin/suppliers-manager/useSuppliersManager.ts | Updates dbInvokeDelete call to object signature. |
| src/components/admin/products/useProductsManager.ts | Updates dbInvokeDelete call to object signature. |
| src/components/admin/products/ProductMarketingSection.tsx | Uses untypedFrom for view update with tags payload. |
| qa/RELATORIO_FINAL.md | QA final report documenting metrics, suites, and remaining tech debt. |
| qa/bugs/BUG-011.md | Documents SECURITY DEFINER audit debt. |
| qa/bugs/BUG-010.md | Documents mockup result/interface mismatch fix. |
| qa/bugs/BUG-009.md | Documents dbInvokeDelete signature mismatch fix. |
| qa/bugs/BUG-008.md | Documents downloadMockupAsPdf signature fix. |
| qa/bugs/BUG-007.md | Documents unused import cleanup. |
| qa/bugs/BUG-006.md | Documents NoveltyCards wrong property path fix. |
| qa/bugs/BUG-005.md | Documents missing icon_color type fix. |
| qa/bugs/BUG-004.md | Documents dev tools module restoration. |
| qa/bugs/BUG-003.md | Documents ProductGrid colors fallback fix. |
| qa/bugs/BUG-002.md | Documents ProductStatusBadge union mismatch fix. |
| qa/bugs/BUG-001.md | Documents ProductCard TDZ fix. |
| qa/02-test-matrix.md | QA test matrix doc. |
| qa/01-recon.md | QA recon report doc. |
| qa/00-baseline.md | QA baseline doc. |
| .eslint-baseline.json | Updates ESLint baseline snapshot and counts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
+5
| import { useEffect, useRef } from 'react'; | ||
| import { motion } from 'framer-motion'; | ||
| import { cn } from '@/lib/utils'; | ||
| import { ArrowUp } from 'lucide-react'; | ||
| import { useAriaLive } from '@/components/a11y'; |
Comment on lines
15
to
17
| import { supabase } from '@/integrations/supabase/client'; | ||
| import { untypedFrom } from '@/lib/supabase-untyped'; | ||
| import { logger } from '@/lib/logger'; |
Comment on lines
+24
to
+26
| // Diagnostic counter | ||
| let catalogRenderCount = 0; | ||
|
|
Comment on lines
+90
to
+91
| catalogRenderCount++; | ||
|
|
Comment on lines
+16
to
22
| const queries: InvokeOptions[] = uniqueIds.map((id) => ({ | ||
| table: 'suppliers', | ||
| operation: 'select' as const, | ||
| select: 'id,name', | ||
| filters: { id }, | ||
| limit: 1, | ||
| cacheKey: `supplier-${id}`, | ||
| })); |
| import '@testing-library/jest-dom'; | ||
|
|
||
| import { render, screen, fireEvent, waitFor } from '@testing-library/react'; | ||
| import { render, screen, fireEvent, act, waitFor } from '@testing-library/react'; |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
promo-gifts-v4/src/components/products/EnhancedProductCard.tsx
Lines 75 to 76 in 5cdbe0c
Render out-of-stock products with the stock badge type
For products whose stockStatus is out-of-stock, this still renders ProductStatusBadge as type="urgency" with an unsupported urgencyType, while the badge's urgency switch only handles limited-stock, trending, and ending-soon. In that scenario the badge falls through to the muted default styling instead of using the destructive out-of-stock branch added in ProductStatusBadge; choose type="out-of-stock" for this branch.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+6
to
+8
| import { ProductGrid } from '@/components/products/ProductGrid'; | ||
| import { ProductList } from '@/components/products/ProductList'; | ||
| import { ProductTableView } from '@/components/products/ProductTableView'; |
There was a problem hiding this comment.
When the catalog route is loaded from the production Vite bundle, these static imports reintroduce the Index -> CatalogContent -> ProductGrid/ProductCard -> index/shared chunk cycle that the previous lazy imports explicitly broke. That cycle can put modules back into TDZ evaluation order and crash the product listing during initial load; keep these view components behind lazy(() => import(...))/Suspense or otherwise break the dependency cycle before restoring static imports.
Useful? React with 👍 / 👎.
| }, [filterKey]); | ||
|
|
||
| // Multi-variant carousel (hoisted before useEffect that depends on it) | ||
| const allMatchingVariants = resolveAllMatchingColors(product.colors, activeColorFilter); |
There was a problem hiding this comment.
When ProductCard.tsx is parsed, this newly added const allMatchingVariants is in the same component scope as the existing declaration a few lines below, so the module fails to compile with a duplicate lexical declaration before any product card can render. Keep a single declaration before the effect that depends on it.
Useful? React with 👍 / 👎.
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA Sprint Completo — Rebased onto main (supersede PR #614)
Este PR é o rebase limpo do PR #614 sobre o main atual (que recebeu hotfixes #615, #616, #617 + push direto enquanto #614 estava aberto). Conflitos resolvidos manualmente preservando as melhores versões de cada arquivo.
🔧 Conflitos resolvidos no rebase
ProductCard.tsxProductGrid.tsx: Productdo PRNoveltyProductGrid.integration.test.tsx.eslint-baseline.jsonCatalogContent.tsxScrollProgress.tsxuseSparklineSales.tsxuseCatalogState.ts📊 Métricas de Qualidade
🐛 Bugs Corrigidos (11 documentados + 13 via code review)
P0 — Crítico
ProductGrid: Rules-of-Hooks violation (hooks após early returns) → crash silencioso em StrictModeProductCard: TDZ —allMatchingVariantsusada antes da declaraçãoP1 — Funcional
NoveltyCards: caminhos errados (product.product.name→product.product_name)ProductStatusBadge: casos switch inalcançáveis (out-of-stocknão no union type)supabase.from()com type drift → migradas parauntypedFrom()dbInvokeDelete: assinatura errada(table, id)→({ table, id })useMockupGenerator:downloadMockupAsPdfcom args incorretosuseSyncExternalStoresnapshot mutável (Cubic)EnhancedProductCard: out-of-stock mapeado para limited-stock badge (Cubic)NoveltyProductGrid: regressão no row click em modo não-seleção (Cubic)P2 — Com Workaround
useProfileRoles:awaitfaltando emgetSupabaseClient()NotificationDrawer: DateRange handler com tipo incompatíveluseSparklineSales: igualdade fraca (!= null)NotificationPreferences: flicker de reload completo no toggle (Cubic)technique.repository:minCores=0range inválido + timestamps instáveis (Cubic)MetricUtils formatBytes: out-of-bounds para ≥ 1TB (Cubic)useCatalogState: 3console.logem produção (Cubic)BridgeMetricsOverlay: painel inalcançável sem toggle button (Codex)useBridgeMetrics: não conectado ao telemetry store (Codex)useProfileRoles: role objects armazenados como objetos vs strings (Codex)DevOnlyBridgeOverlay: sem gating viauseDevGate(Codex)🧪 Cobertura de Testes
📁 Arquivos modificados: 90 (componentes, hooks, lib, testes, docs QA)
🗒️ Dívida técnica documentada
SECURITY DEFINER— auditoria DBA pendente (BUG-011)charts-vendor455KB,xlsx500KB,hls523KB — lazy-load progressivosupabase gen types typescriptno CI elimina a causa raiz do type driftFecha: #614, #607
Summary by cubic
Full QA sprint rebased onto main. Drops 337 TypeScript errors to 0, fixes 11 bugs, and adds dev telemetry, QA docs, and 105+ tests to stabilize catalog, novelties, mockup, and admin flows.
Bug Fixes
out-of-stockbadge and updated EnhancedProductCard urgency logic.dbInvokeDeleteto{ table, id }; fixeddownloadMockupAsPdfcall and result shape (singleUrl,batchResults).useProfileRolesasync/role mapping; tightened types in search and command bar.NotificationPreferencesoptimistic toggle when the category entry is missing.Refactors
supabase.from()calls tountypedFromfor untyped tables; aligned callers toInvokeOptions/InvokeResult.BridgeMetricsOverlay,DevOnlyBridgeOverlay) anduseBridgeMetricswith immutable snapshots and dev gating; improvedMetricUtils.formatBytes.mainwith cleanup of imports/logs and tighter query/config types.Written for commit f260b12. Summary will update on new commits.