codex 1#290
Conversation
* refactor(theme): sweep -orange* → -brand-primary* (chunk 1/8 — Etapa 17 fase 2) * refactor(theme): sweep -orange* → -brand-primary* (chunk 2/N — Etapa 17 fase 2)
Co-authored-by: Codex Simulation <codex-simulation@example.local>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
d7045f6
into
codex/reuse-approved-branch-patches
* fix(contracts): remove duplicate CONTRACTS import * fix(auth): preserva isConfig p/ provider desabilitado (provider_is_not_enabled) mapOAuthError passou a retornar mensagem PT-BR amigável, mas isso fazia resolveOAuthError cair no fallback genérico (isConfig=false), reexibindo o botão "Tentar Google Novamente" para uma falha de CONFIG que não tem solução client-side. Adiciona heurística em resolveOAuthError que reconhece "não está habilitado"/"not enabled" → copy provider_is_not_enabled (isConfig). [Codex review] https://claude.ai/code/session_01SN7BG6cYaPS1t1fYLkga4Z * fix(ui): gateia transforms do botão Google atrás de motion-safe Mesmo bug do login-submit (#3): o botão social-login-google tinha 'transition-all hover:scale-[1.01] active:scale-[0.98]' SEM gate motion-safe. Sob o reducedMotion:'reduce' do CI o transform seguia animando a cada hover/mousedown -> 'locator.click: Timeout' no smoke 40 (e o waitForRequest era sintoma do clique nao registrar). Gateado, o botao fica estatico e clicavel sob reduced-motion. * test(contracts): port reusable webhook coverage * chore(ci): refresh lint and typecheck baselines * codex 1 (#290) * Etapa 17 fase2 sweep orange to brand primary (#288) * refactor(theme): sweep -orange* → -brand-primary* (chunk 1/8 — Etapa 17 fase 2) * refactor(theme): sweep -orange* → -brand-primary* (chunk 2/N — Etapa 17 fase 2) * ci: harden deploy gate baselines (#287) Co-authored-by: Codex Simulation <codex-simulation@example.local> --------- Co-authored-by: Codex Simulation <codex-simulation@example.local> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Codex <codex@local> Co-authored-by: Codex Simulation <codex-simulation@example.local>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb509532f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (ms < 200) return 'text-emerald-400'; | ||
| if (ms < 600) return 'text-amber-400'; | ||
| if (ms < 1500) return 'text-orange-400'; | ||
| if (ms < 1500) return 'text-brand-primary-400'; |
There was a problem hiding this comment.
Replace undefined Tailwind class for latency color
The new class text-brand-primary-400 is not defined by this project's Tailwind theme (the brand-primary color only exposes semantic keys like DEFAULT, hover, active, etc.), so this branch will not generate a CSS rule and latency values between 600ms and 1499ms lose their intended warning color in the metrics UI. Use an existing token such as text-brand-primary (or add a real 400 shade in the theme) to avoid the silent styling regression.
Useful? React with 👍 / 👎.
📋 Descrição
🎯 Tipo de mudança
🔗 Issues relacionadas
Closes #
Refs #
🌐 Sistemas afetados
🧪 Como testar
✅ Checklist pré-merge
Qualidade
npx tsc --noEmitpassa sem errosnpm run test)Segurança
console.logcom payloads sensíveis (usarlogger.*)Documentação
mem://) se a mudança afetar arquitetura/regras_backup_*_YYYYMMDDse destrutivasUI
📸 Screenshots (se UI)
🔄 Plano de rollback
Summary by cubic
Aligns brand styling to use our
brand-primarycolor and hardens CI by standardizing Node with.nvmrcand upgrading GitHub Actions. Also updates Lighthouse and SEO entries to point to/authand avoid duplicate meta tags.Refactors
-orangeto-brand-primaryacross UI (loading spinner, admin approvals, image gallery, scroll-to-top, urgency badge, metrics)./loginto/auth.data-rh="true"to canonical and social URL meta tags to prevent duplicates.Dependencies
.nvmrcin workflows and upgrade toactions/checkout@v5andactions/setup-node@v6.continue-on-error: true./auth, relax ready pattern, and remove thelighthouse:recommendedpreset while keeping explicit score assertions.Written for commit bb50953. Summary will update on new commits. Review in cubic