Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#30: Replace shell script with Python #31

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

#30: Replace shell script with Python #31

wants to merge 17 commits into from

Conversation

in0rdr
Copy link
Collaborator

@in0rdr in0rdr commented Sep 12, 2024 •
edited
Loading

Done:

  • Take snapshot from VAULT_ADDR using a VAULT_TOKEN (don't store to file, keep it in mem)
  • Upload file stream (python requests lib) to s3 using boto3

Todo:

  • Kubernetes auth (almost done)
  • Iteration through objects for retention purposes
  • Make it pretty ✨ (well, write some tests)

@in0rdr in0rdr linked an issue Sep 12, 2024 that may be closed by this pull request
Replace shell script with Python #30
Open
Base automatically changed from feat/remove-expired-snapshots to master September 12, 2024 22:11
@in0rdr in0rdr marked this pull request as ready for review November 25, 2024 21:40
@in0rdr in0rdr changed the title #30: Draft Python code #30: Replace shell script Python Nov 25, 2024
@in0rdr in0rdr changed the title #30: Replace shell script Python #30: Replace shell script with Python Nov 25, 2024
@in0rdr in0rdr requested review from eyenx and tongpu November 26, 2024 14:32
@in0rdr
Copy link
Collaborator Author

in0rdr commented Nov 26, 2024

@tongpu @eyenx I tested this with https://github.com/adfinis/vault-playground-on-kubernetes against some local Minio. Do you think it makes sense to test in a more realistic environment? It would be quite a major/breaking change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyenx eyenx Awaiting requested review from eyenx

@tongpu tongpu Awaiting requested review from tongpu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace shell script with Python
1 participant
@in0rdr