Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session service is not return user info with ember data model #26

Closed
MitanOmar opened this issue Apr 18, 2024 · 4 comments · Fixed by #150
Closed

session service is not return user info with ember data model #26

MitanOmar opened this issue Apr 18, 2024 · 4 comments · Fixed by #150
Assignees
Labels
bug Something isn't working frontend This issue or pull request is frontend related UX This issue or pull request is UX related

Comments

@MitanOmar
Copy link
Member

MitanOmar commented Apr 18, 2024

Describe the bug
Timed use ember-simple-auth-oidc, which it's built in top of ember-simple-auth,
when first time login, the session service including the data of the current user info and it's an instance of data model

but when the token is expire, ember-simple-auth-oidc refresh the token, but the user information is a pure object that come from keycloak, without encapsulating it inside ember data model and we can not access the helper that defined in user data model

To Reproduce
open multi timed tab, and go to https://timed.adfinis.com/reports and in another page go to https://timed.adfinis.com/analysis page, and wait a few minutes until you are sure the token is expire

Screenshots
in the console, you got a lot of this error, and each time you select a report or try to change the date of timesheet, you get another error.
and the source of this error coming from Report Abilities file

Screenshot

and there is an open merge request to give a temporary solution to ignore this issue adfinis/timed-frontend#1199

@MitanOmar MitanOmar added the bug Something isn't working label Apr 18, 2024
@MitanOmar MitanOmar self-assigned this Apr 18, 2024
@c0rydoras c0rydoras transferred this issue from adfinis/timed-frontend May 13, 2024
@derrabauke
Copy link
Contributor

adfinis/timed-frontend#1201 this needs to be migrated to this new repo!

@MitanOmar
Copy link
Member Author

i am checking the PR, and i will include it

@c0rydoras c0rydoras added the frontend This issue or pull request is frontend related label May 13, 2024
@c0rydoras
Copy link
Collaborator

@derrabauke it has been ported and merged: #150

@c0rydoras c0rydoras linked a pull request May 14, 2024 that will close this issue
@c0rydoras c0rydoras added the UX This issue or pull request is UX related label May 14, 2024
@c0rydoras
Copy link
Collaborator

Tested and confirmed to be fixed in https://github.com/adfinis/timed/tree/v4.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend This issue or pull request is frontend related UX This issue or pull request is UX related
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants