Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: frontend #483

Open
wants to merge 81 commits into
base: main
Choose a base branch
from
Open

Conversation

c0rydoras
Copy link
Collaborator

@c0rydoras c0rydoras commented Oct 2, 2024

  • use adfinis ci (colors)
  • get rid of adcssy.scss (and all other scss)
  • support for dark mode (very experimental, add dark class to <html>)
  • fix some bugs
    • comments can only be deleted if they exist
    • the save button is disabled if the report is invalid
    • some visual bugs

@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 3 times, most recently from 3d77b08 to ab8126e Compare October 2, 2024 08:34
@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 4 times, most recently from e5540ba to 5f4bbee Compare October 2, 2024 10:10
@derrabauke
Copy link
Contributor

Just as a note for later: The same needs to be done for the customer-center

@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 10 times, most recently from debab36 to 37abeff Compare October 4, 2024 12:18
@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 8 times, most recently from e5bd6e1 to dc1cf6b Compare October 21, 2024 07:31
@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 2 times, most recently from aeac3af to 76dc6c8 Compare October 28, 2024 13:35
@c0rydoras c0rydoras requested a review from a team as a code owner November 5, 2024 13:30
@hairmare
Copy link
Contributor

hairmare commented Nov 5, 2024

When i select an archived project in the projects tab, it looks like this:

image

It should look more like it used to:

image

@hairmare
Copy link
Contributor

hairmare commented Nov 5, 2024

when i click on a menu in mobile view i end up here:

image

would be nice if the menu could collapse on click

@tongpu
Copy link
Member

tongpu commented Nov 6, 2024

The needs attention thingy is misaligned:
image

@patricflueckiger
Copy link

image
Are the buttons aligned here as they should?

@c0rydoras
Copy link
Collaborator Author

Current State (this is also deployed):

@weberval
Copy link

weberval commented Nov 6, 2024

Nice work. The UI looks great.

The new UI is a bit less dense than the previous one.
During my test, I had the impression that the new UI is a little less clear due to this.

I can understand, that big buttons are desired for use with touchscreens. However, this tool is mostly used on desktop devices using a mouse style pointing device. As a compromise, would it be possible to bring back a more dense versions for wide screen desktop devices?

@tongpu
Copy link
Member

tongpu commented Nov 6, 2024

One thing which has bothered me in the past and could maybe be improved with an UI overhaul is that the delete button for attendences is all the way to the right, while the UI element you usually interact with is in the middle of the screen.
image
Would that be a change we could consider with the refactoring?

@c0rydoras
Copy link
Collaborator Author

@tongpu like this?

image

@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 3 times, most recently from b78736e to 34ca9c7 Compare November 6, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Update colors [REFACTOR]: get rid of adcssy.scss
6 participants