fix(cleanup): convert cleanup migration to command #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anehx
force-pushed
the
convert-migration-to-command
branch
from
2f87637
to
3726786
Compare
winged
requested changes
Jan 21, 2022
| if ( | ||
| path not in used_files | ||
| and os.path.isfile(path) | ||
| and path.endswith(".docx") |
There was a problem hiding this comment.
Not sure this endswith restriction is actually needed
| if not options.get("dry"): | ||
| os.remove(path) | ||
| self.stdout.write( | ||
| self.style.SUCCESS(f"Deleted dangling file '{path}'") |
There was a problem hiding this comment.
Suggestion: change the message depending on dry mode
The cleanup migration is too dangerous since it will possibly delete production data if something goes wrong. This commit converts the migration to a command which can be called manually and has a dry run option to test it beforehand.
anehx
force-pushed
the
convert-migration-to-command
branch
from
3726786
to
7373a1e
Compare
winged
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup migration is too dangerous since it will possibly delete production data if something goes wrong. This commit converts the migration to a command which can be called manually and has a dry run option to test it beforehand.