fix(select): fix promptIsSelectable in combination with targetPath (#853

)
adfinis · Sep 2, 2022 · 526d81f · 526d81f
1 parent 100aa9e
commit 526d81f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/addon/components/validated-input/types/select.js b/addon/components/validated-input/types/select.js
@@ -125,7 +125,9 @@ export default class SelectComponent extends Component {
 
     //single select
     const foundOption = options.find((item) => getValue(item) === target.value);
-    if (targetPath) {
+
+    // If @promptIsSelectable is set to true, foundOption in this case will be undefined.
+    if (targetPath && foundOption) {
       return foundOption[targetPath];
     }
     return foundOption;

diff --git a/tests/integration/components/validated-input/types/select-test.js b/tests/integration/components/validated-input/types/select-test.js
@@ -254,5 +254,32 @@ module(
 
       await select("select", ["1", "2"]);
     });
+
+    test("prompt is selectable in compination with optionTargetPath, optionValuePath and optionLabelPath", async function (assert) {
+      assert.expect(3);
+      const values = [2, undefined];
+      this.set("options", [
+        { value: 1, text: "one" },
+        { value: 2, text: "two" },
+      ]);
+      this.set("update", (value) => {
+        assert.strictEqual(value, values.shift());
+      });
+
+      await render(
+        hbs`<ValidatedInput::Types::Select
+          @update={{this.update}}
+          @options={{this.options}}
+          @prompt="Choose this"
+          @promptIsSelectable={{true}}
+          @optionLabelPath="text"
+          @optionTargetPath="value"
+          @optionValuePath="value" />`
+      );
+
+      await select("select", "2");
+      await select("select", "option:first-child");
+      assert.dom("option:first-child").hasProperty("disabled", false);
+    });
   }
 );