Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toast): ♻️ add new toast state & examples #199

Merged
merged 14 commits into from
Mar 31, 2021

Conversation

navin-moorthy
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/timelessco/renderlesskit-react/2sKkJrde22uUkqdHR25EueY1vLbx
✅ Preview: https://renderlesskit-react-git-new-toast-state-timelessco.vercel.app

@navin-moorthy navin-moorthy changed the base branch from master to toast-updated-fix February 26, 2021 14:01
@navin-moorthy navin-moorthy changed the title feat: pass index to toast wrapper refactor(toast): ♻️ add new toast state & examples Mar 1, 2021
@navin-moorthy navin-moorthy changed the base branch from toast-updated-fix to master March 1, 2021 13:40
@anuraghazra
Copy link
Contributor

Can we make this examples to consistent placement buttons instead of adding the toast in random places? Bit wierd to play around with random placement on each click .

image

@navin-moorthy
Copy link
Collaborator Author

Can we make this examples to consistent placement buttons instead of adding the toast in random places? Bit wierd to play around with random placement on each click .

image

Right ! I will place it in the bottom-center so that it looks centered in mobile also.

src/toast/Toasts.tsx Outdated Show resolved Hide resolved
src/toast/index.ts Outdated Show resolved Hide resolved
@navin-moorthy navin-moorthy merged commit e62928f into master Mar 31, 2021
@navin-moorthy navin-moorthy deleted the new-toast-state branch March 31, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants