Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wip runtime ts transpile examples #129

Merged
merged 11 commits into from
Nov 2, 2020
Merged

Conversation

anuraghazra
Copy link
Contributor

No description provided.

@anuraghazra anuraghazra added documentation 📚 Improvements or additions to documentation enhancements 📈 Improve an existing Feature labels Oct 30, 2020
@netlify
Copy link

netlify bot commented Oct 30, 2020

Deploy preview for renderless-components ready!

Built with commit 38a667f

https://deploy-preview-129--renderless-components.netlify.app

@@ -2,6 +2,7 @@ module.exports = {
stories: ["../src/**/*.stories.@(js|jsx|ts|tsx)"],
addons: [
"storybook-addon-preview",
"@storybook/addon-docs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To suppress warning in Storybook cli logs.
addon-docs must be loaded before controls

@@ -0,0 +1,22 @@
import * as ts from "typescript";
Copy link
Collaborator

@navin-moorthy navin-moorthy Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import gives a webpack warning, hence added a plugin to suppress that warning

@navin-moorthy navin-moorthy merged commit 5a4729f into master Nov 2, 2020
@navin-moorthy navin-moorthy deleted the runtime-ts-transpile branch November 2, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 Improvements or additions to documentation enhancements 📈 Improve an existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants