Skip to content

New: Migration scripts added to repo (fixes #111) #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 26, 2025
Merged

New: Migration scripts added to repo (fixes #111) #112

merged 28 commits into from
Mar 26, 2025

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jan 27, 2025 •
edited
Loading

Fix #111

Part of adaptlearning/adapt_framework#3631

New

  • Migration scripts added to repo

Migration milestones

5.1.0

  • _graphic._url added
  • _graphic._target added

6.2.0

  • Added _graphic.longdescription
  • Added _isScrollable
  • Added _defaultScrollPercent
  • Added scrollAriaLabel to globals - different commit, but same tag 6.2.0

6.2.5

  • Update default _graphic._target

Example legacy config

You can use this for testing the migration.

{
  "_id": "c-105",
  "_parentId": "b-100",
  "_type": "component",
  "_component": "graphic",
  "_classes": "",
  "_layout": "right",
  "title": "c-105",
  "displayTitle": "",
  "body": "",
  "instruction": "",
  "_graphic": {
    "alt": "",
    "large": "course/en/images/single-width.png",
    "small": "course/en/images/single-width.png",
    "attribution": ""
  },
  "_isOptional": true
},

@swashbuck swashbuck self-assigned this Jan 27, 2025
@swashbuck swashbuck marked this pull request as ready for review January 28, 2025 21:06
joe-allen-89
joe-allen-89 previously requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few styling changes/queries but looking good.

@swashbuck
Copy link
Contributor Author

Thanks, @joe-allen-89 . This is really helpful, and I can use this advice on other migrations PRs.

I believe I've made all the changes you requested. Also note that I was incorrectly putting _url and _target in the wrong place (i.e. not on the _graphic object), but that should be fixed now.

joe-allen-89
joe-allen-89 reviewed Feb 18, 2025
View reviewed changes
@joe-allen-89 joe-allen-89 merged commit e6b15da into master Mar 26, 2025
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 26, 2025
github-actions bot pushed a commit that referenced this pull request Mar 26, 2025
@semantic-release-bot
Chore(release): 6.3.0 [skip ci]
74218c4 
# [6.3.0](v6.2.11...v6.3.0) (2025-03-26)

### Chore

* Add support for new issue experience (fixes #110) (#115) ([36eec21](36eec21)), closes [#110](#110) [#115](#115)

### New

* Migration scripts added to repo (fixes #111) (#112) ([e6b15da](e6b15da)), closes [#111](#111) [#112](#112)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement ready to release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add migration scripts to the repo
2 participants
@swashbuck @joe-allen-89