feat(framework) Add abstract user auth plugin #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnugraha
requested review from
tanertopal and
danieljanes
as code owners
panh99
reviewed
Dec 3, 2024
panh99
reviewed
Dec 3, 2024
panh99
previously approved these changes
Dec 4, 2024
panh99
approved these changes
Dec 4, 2024
panh99
force-pushed
the
add-abc-auth-plugin
branch
from
2fbce91 to
ac839bb
Compare
panh99
force-pushed
the
add-abc-auth-plugin
branch
from
5d3eb8b to
473cd86
Compare
panh99
previously approved these changes
Dec 6, 2024
panh99
force-pushed
the
add-abc-auth-plugin
branch
from
da5de46 to
ac88a18
Compare
panh99
reviewed
Dec 8, 2024
jafermarq
reviewed
Dec 9, 2024
| @abstractmethod | ||
| def login( | ||
| login_details: dict[str, str], | ||
| config: dict[str, Any], |
There was a problem hiding this comment.
Wouldn't it better to make use of some of the types we have for configs ? For example
flower/src/py/flwr/common/typing.py
Line 65 in fc8591f
There was a problem hiding this comment.
This function expects a json dictionary here, and it would be rather flexible if we just use dict[str, Any]. Though we normally just need to store scalars in the json dict, I am not quite sure what's the benefit of enforcing a stricter type here.
There was a problem hiding this comment.
It receives a {string: string} (
flower/src/proto/flwr/proto/exec.proto
Line 67 in 0730b12
exec.proto. Happy to leave it as Any, but in other parts of the code we are more strict with these things (e.g. typing.UserConfig)
danieljanes
reviewed
Dec 9, 2024
danieljanes
reviewed
Dec 10, 2024
danieljanes
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR introducing user authentication. The changes include:
ExecAuthPluginandCliAuthPlugin.Please merge #4244 first before merging this PR.