refactor(datasets) Rename SizePartitioner to IdToSizeFncPartitioner #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
adam-narozniak
changed the title
jafermarq
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The name
SizePartitionerdoes not reflect the code of the formerSizePartitioner.Description
The idea of the former
SizePartitioneris to enable the automatic creation of the mapping id to size based on the relationship between the id and the size. Such function dictates the created sizes.Related issues/PRs
todo: paste the new true
SizePartitionerProposal
Rename to
IdToSizeFncPartitioner. Before a longer version was considered:IdToSizeFunctionPartitioner