-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
\ufbab
character does not work anymore
#64
Comments
Thanks for reporting this. I'm still camping but will be back in civilized regions on the weekend. It would help me finding the glyph if you could copy&paste it into a comment here (it may render wrong/differently in the browser but that does not matter). |
Sure: Have a great time! |
You gave the unicode code in the title 🤦 Great! Those who can read but do not have no advantage on those who can not read... |
Well, The top shows the regular font, where Cascadia added arab glyphs recently. We never overwrite existing glyphs, so we do not add the hourglass. Note the differing descriptive name (that we do not alter on existing glyphs obviously). The very small pictures above always shows what the font's glyph should roughly look like. With the bottom font most glyphs are filled correctly (according to unicode), but unexpected to ppl using that codepoints as empty and add symbols there. See https://github.com/microsoft/cascadia-code/releases/tag/v2106.17 that arab has been added. Now we face the decision to remove arab or move the symbols to unexpected locations, or .... *ponder* |
Here is an overview of all glyphs that prevent patching some symbols in. Almost all come with the MaterialDesignIcons.
|
If we would drop the Arabic and Hebrew Letters, we end up with this set:
|
Here the conflicting glyphs: I think we want to keep the ligatures, and maybe the parens are more useful then the video symbols. This would mean:
Edit: Correct image, did use wrong font |
So if I want to use Hebrew I can't use Delugia font? |
Neither. Pure Powerline symbols are already in In fact if you just need Powerline symbols you can/should use The problem comes in with the So it is the same problem not for all powerline fonts, but for all Nerd Fonts. But you are somehow right and it was good that you commented, somehow I thought 'noone would ever want to use that glyphs, right?' which is of course ... my fault 😞 So our decision space is in fact a bit more broad. Let me state the facts and possible solutions that I see in the next comment. |
For my use case (Windows Terminal), I have no problem with changing my characters to another code point. |
Problem StatementArabic and Hebrew letters, recently added to Cascadia Code, occupy the same code points as some symbols we want to patch in. Problem DetailsMaterial Design Icons occupy Why do they shift it? The Unicode Blocks are defined as this: Private Use Area Originally the Material Design Icons occupy the private area which is fine. Solution Ideas
Solution 1 is anglocentric and is not desirable in a global world imho. 'normal' means as defined by Nerd Fonts, the Material Design Icons originally sit at other code points anyhow. I will search for another slot. |
ACK. I got side tracked (real work), will continue here later... |
@Finii thanks for the detailed and comprehensive answer. I downloaded and tried the latest version of Delugia font. It actually works pretty well for Hebrew as is right now So I think it might be a viable option to shift Hebrew / Arabic to another range because the glyphs I see here for Hebrew are quite rare, as they include punctuation. This day and age it's almost never used. I estimate the number of users that use punctuation in their terminal to be close to zero... However, need someone who can verify if it's the same for Arabic. Maybe the shifted characters are commonly used in Arabic. Anyway, the solution most likely will shift an existing range position - how should a user adjust character to the new position of the shifted glyphs? |
Here an overview where Nerd Fonts places the symbols sorted by destination codepoint:
What I see here is a nice gap from to be continued |
Yesterday I came up with the following possible solutions. They all shift part of the Material Design Icons to another range, because there is no unfragmented large enough chunk of code points in a private area available. Well, in fact there is the block Supplementary Private Use Area-A ( In reply to @sinapis:
I believe it is impossible to shift the letter characters. Usually there is some means to enter them (apart from inputting raw codes), and that needs to be tweaked. Which is hard. Shifting the symbols on the other hand is not so hard. Some prepared nice looking setups might break, but usually the symbols are entered by raw code numbers, and so that has to be adjusted once in the individual setup. Not nice but viable. For that reason I do not consider shifting the letters. Either drop them or keep them in their rightful places. Split Range Variant AWhen we try to
we could relocate:
Split Range Variant BWe can sacrifice the CJK Compatibility Ideographs block (
Split Range Variant CWhen we do not try to keep the hex codes similar we can create less fragmentation in the user map, by doing:
An then I noticed this: WAT? 6 Octicons are immediately overwritten by Material Design Icons? Who designed that relocation table? I need to investigate that. |
Regarding the Octicons... The table is misleading. The source range is examined, and only filled glyphs are copied to the destination range, but packed (with no non-filled slots in the destination). There are only 169 (0xA9) glyphs in the Edit: Correct Destination address |
Per ryanoasis/nerd-fonts#365 this is a known issue with the Nerd Fonts placement of Material Design. I had hoped it would be sorted by now but alas. I would strongly recommend against “sacrificing” the CJK slots (especially as I would like to fill them) and instead suggest use of Supplementary PUA A or B (https://www.unicode.org/charts/PDF/UF0000.pdf) which have more than enough spots to accommodate the full Material Design glyphs. This is where I planned to put them :). Otherwise we will be having this conversation again in the future… |
Some more information about this at Nerd Fonts: ryanoasis/nerd-fonts#365 (comment) |
Actually we are ahead of Nerd Fonts' With the latest update to Nerd Fonts Whatever. Use this table to get the new codepoints for your missed / existing codepoints of MaterialDesignIcons: From the table you see that you can access On some systems you need to use https://www.nerdfonts.com/cheat-sheet If you are using oh-my-posh, this might be interesting: Edit: Add info on oh-my-posh |
I'm using Windows Terminal with PowerShell (
pwsh.exe
)Before with
Delugia Nerd Font
Version22d4cae
(v2105.24):Now with
Delugia
(Delugia-Complete.zip
),v2105.24-1-ga2e91f1
:The text was updated successfully, but these errors were encountered: