Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: Add metadata kwarg to send_data method #92

Closed
brentru opened this issue Mar 1, 2019 · 1 comment
Closed

Client: Add metadata kwarg to send_data method #92

brentru opened this issue Mar 1, 2019 · 1 comment
Assignees
@brentru
Labels
enhancement

Comments

@brentru
Copy link
Member

brentru commented Mar 1, 2019

Refactor existing send_data method to include location (lat/lon/ele) and created_at (not currently supported) metadata as a list, rather than having an additional send_location_data method.

Similar to the implementation in Adafruit IO CircuitPython:
https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/master/adafruit_io/adafruit_io.py#L136

Note: create_data will also need to include a path for the metadata
@brentru brentru self-assigned this Mar 1, 2019
@brentru brentru mentioned this issue Mar 5, 2019
Merged
@brentru
Copy link
Member Author

brentru commented Mar 5, 2019

Merged PR #93 into master, closing...

@brentru brentru closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentru brentru

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brentru