Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake in _read_data #19

Closed
kolcz opened this issue Apr 3, 2024 · 2 comments
Closed

Mistake in _read_data #19

kolcz opened this issue Apr 3, 2024 · 2 comments

Comments

@kolcz
Copy link
Contributor

kolcz commented Apr 3, 2024 •
edited
Loading

adafruit-circuitpython-scd4x version 1.4.2

In method _read_data of class SCD4x is mistake in calculating self._temperature and **self._realtive_humidity. Denominator is missing "- 1" according to documentation.
Code snippet from library from pip:
image

Fragment from Data Sheet:
image
@kolcz
Copy link
Contributor Author

kolcz commented Apr 3, 2024

#20

@FoamyGuy
Copy link
Contributor

resolved by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FoamyGuy @kolcz