Update peripherals.py to include a new get_display_config function #3
Conversation
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
I updated this to access values from the instantiated display rather than the ones on picodvi.FrameBuffer which are like meta definitions of properties I think, not returning the plain values.
This looks good to me now, thanks for the new function and issues for feature requests.
I'll work on updating the request config function next to support color_depth and use Sam's logic to avoid re-setting the same configurations.
|
Thanks Tim, looks great! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_Color_Terminal to 0.2.0 from 0.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Color_Terminal#2 from FoamyGuy/bell_and_fruitjam_example Updating https://github.com/adafruit/Adafruit_CircuitPython_FruitJam to 0.3.0 from 0.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_FruitJam#4 from FoamyGuy/color_depth_support > Merge pull request adafruit/Adafruit_CircuitPython_FruitJam#3 from adafruit/TheKitty-patch-1
This new function polls picoDVI for the current configuration. It returns a None tuple if undefines and the resolution in width, height, pixel_depth if it exists.
Feel free to tweak.