Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we diable folder-image generation for other forks? #404

Open
FoamyGuy opened this issue Sep 30, 2022 · 0 comments
Open

Should we diable folder-image generation for other forks? #404

FoamyGuy opened this issue Sep 30, 2022 · 0 comments

Comments

@FoamyGuy
Copy link
Contributor

The images.yml file has a scheduled task that runs once per day to generate the folder images for all example code from the libraries in the bundle.

on:
schedule:
- cron: '0 10 * * *'
workflow_dispatch:

It seems this scheduled task runs on all forks of this repo (assuming their default branch is up-to-date enough to contain the images.yml file). Here is an output from that workflow running in my fork: https://github.com/FoamyGuy/Adafruit_CircuitPython_Bundle/actions/runs/3162062950 I checked one or two others at random and did find more with the scheduled workflow in it.

Should we add some sort of limitation that makes this action only run for the adafruit org fork of the repo's instead of everyones? The generated images in adafruit org are the only ones that are widely used AFAIK

We use a limitation like that here: https://github.com/adafruit/circuitpython/blob/bced76887e49e0a30a0e116ef5a4feed7f3d240e/.github/workflows/build.yml#L118

github.repository_owner == 'adafruit'

It could perhaps be used similarly in this image generator workflow to limit it so it won't run for other users (unless they modify the workflow.yml file to change it).

If we decide to make this change, it's probably worthwhile to do the same thing over in the Learn Guide repo because It uses the same type of cron scheduled workflow that also seems to run for other users as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant